Fix dive_client_cli lint error. #605
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hysw
commented
Nov 27, 2025
hysw
commented
- Remove unused includes.
- Fix almost all clang-tidy issues.
- Remaining cppcoreguidelines-pro-bounds-array-to-pointer-decay need to be fixed in constants.h
- Rewrite array initialization.
hysw
force-pushed
the
lint-dive_client_cli
branch
3 times, most recently
from
0ae56d6 to
4e4a2bb
Compare
- Remove unused includes. - Fix almost all clang-tidy issues. - Remaining cppcoreguidelines-pro-bounds-array-to-pointer-decay need to be fixed in constants.h - Rewrite array initialization.
hysw
force-pushed
the
lint-dive_client_cli
branch
from
4e4a2bb to
3f105ec
Compare
angela28chen
approved these changes
Nov 27, 2025
elviscapiaq
reviewed
Nov 27, 2025
|
|
||
| absl::StatusOr<std::string> capture_file_path = client.StartPm4Capture(); | ||
| if (!capture_file_path.ok()) | ||
| std::string capture_file_path; |
Collaborator
There was a problem hiding this comment.
Absel recommends to treat an StatusOr as a pointer. That means, we should dereference this to get its value (*capture_file_path). Ref: https://abseil.io/tips/181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.