Adding additional info in the UI for GFXR draw calls #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela28chen
force-pushed
the
index-vertex
branch
from
e48da00 to
6e04333
Compare
hysw
reviewed
Dec 3, 2025
Collaborator
Author
|
Manual Testing (last: 2025/12/03 3:50)
|
hysw
reviewed
Dec 3, 2025
wangra-google
approved these changes
Dec 3, 2025
hysw
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight some important parameters of the Vulkan vkCmdDraw* commands by adding them to the node description, namely the vertex count, index count, and instance count.
Minor changes:
current_pathparameter fromGfxrVulkanCommandHierarchyCreator::GetArgs()m_node_root_node_indicesmember fromGfxrVulkanCommandHierarchyCreator