-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Clipped children when using flexWrap="wrap"
and large width divider
#525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Having a quick look through the source, it looks like the dividers are taken into account for layout, but not when measuring children. |
I think this issue also affects |
Thanks for reporting. Let me take a look |
Found that ItemDecorations length wasn't taken into account when judging if a line wrapping was required for FlexboxLayoutManager, which should be fixed by #541 . But looks like FlexboxLayout took the divider's length into account when judging if a line wrapping is required (measure phase). I'll continue investigating it. |
Is there any update on when the PR #541 will be merged? It's been a year and a half now 👀 |
I've been dealing with the same issue. Would love to know when this gets merged as well |
Is there any update on this issue? It's been a little over three years now 👀 |
Issues and steps to reproduce
Below you can see a screenshot of a
FlexboxLayout
, which is clipping it's children:The layout is defined as so:
The dividers are implemented like so:
vertical_spaced_divider.xml
horinzontal_spaced_divider.xml
Expected behavior
I expect the children to not be constrained horizontally, and the title text of each item stays on 1 line.
Each of the children has a width of
wrap_context
, so FlexboxLayout should be moving the item to the next line if there is not enough space.If I remove the divider, the items are wrapped as expect.
Version of the flexbox library
2.0.0
The text was updated successfully, but these errors were encountered: