Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pacifico #7066

Open
EbenSorkin opened this issue Dec 6, 2023 · 17 comments · May be fixed by #7309
Open

Update Pacifico #7066

EbenSorkin opened this issue Dec 6, 2023 · 17 comments · May be fixed by #7309
Assignees
Labels
I Font Upgrade II African Mostly west african non-latin and African indigenous scripts III Expand glyphset more features and more language coverage P3
Milestone

Comments

@EbenSorkin
Copy link
Collaborator

Font Project Git Repo URL: https://github.com/Black-sage/Pacifico

Current version: 3.00

New available version: 3.01

Super short description of the upgrade:
Expand glyphset to Africa Pri

Bugs reported in this repo which this upgrade would fix:
No issues in seen in repo.

**Notes: **
• This is an older repo and it lacks fontbakery checks and some documentation that is now standard.
• It may be that this branch should be merged with this one: https://github.com/Fonthausen/Pacifico IDK
• This font passes it's CCMP tests for PRI and even some SSA.

@RosaWagner RosaWagner added this to the 2024 Q1 milestone Dec 6, 2023
@RosaWagner RosaWagner added the III Expand glyphset more features and more language coverage label Dec 6, 2023
@emmamarichal emmamarichal moved this from Todo to In Progress in Google Fonts Dec 6, 2023
@emmamarichal emmamarichal moved this from In Progress to PR Upstream in Google Fonts Dec 7, 2023
@emmamarichal emmamarichal moved this from PR Upstream to PR GF in Google Fonts Dec 14, 2023
@emmamarichal
Copy link
Collaborator

Hi @EbenSorkin and @Black-sage!

@vv-monsalve noticed some tofu when she tested the font with the DinkaNuer text sample. #7104 (comment)

I checked, and it seems that Gamma-latin and gamma-latin are missing ( Ɣ / ɣ -> U+0194 and U+0263).
There are in the GF_Latin_African.glyphs, could you add it?

@Black-sage
Copy link

Black-sage commented Jan 18, 2024

@emmamarichal @EbenSorkin
Hello Emma,I think that is a misunderstanding. For the Pacifico extension, I was assigned to cover the GF_Latin_PriAfrican.glyph glyphset not the GF_Latin_African.glyph. The Gamma-latin does not fall under the GF_Latin_PriAfrican.glyph

@vv-monsalve vv-monsalve added the II African Mostly west african non-latin and African indigenous scripts label Jan 18, 2024
@vv-monsalve
Copy link
Collaborator

Thanks, @Black-sage, for the clarification.

@EbenSorkin, from the SSA sample texts in Octo-Text, could you provide us with a list of the ones covered by the Pri glyphset so that we can perform differentiated proofs.

@EbenSorkin
Copy link
Collaborator Author

EbenSorkin commented Jan 18, 2024 via email

@emmamarichal
Copy link
Collaborator

emmamarichal commented Feb 2, 2024

Hi @EbenSorkin and @Black-sage!

@EbenSorkin, I made some tests with the sample you've made: https://github.com/SorkinType/octo-text/tree/main/Output/7%20African%20Language%20Textures

I tested with African Kern Test Starting with GF African Pri Lc.txt and African Kern Test Starting with GF African Pri UC.txt

L᷊ and l᷊ seem to be missing. Did I use the correct sample text to test it?

Screenshot 2024-02-02 at 12 13 57 Screenshot 2024-02-02 at 12 14 47

@EbenSorkin
Copy link
Collaborator Author

L᷊ and l᷊ are part of Pri now?

@emmamarichal
Copy link
Collaborator

@EbenSorkin
Don't know, but they are in the tests you've made called "African Kern Test Starting with GF African Pri Lc.txt"
If they are not, at least we should update or find appropriate sample text to test Pri.
Do you know were are the more recents?

@EbenSorkin
Copy link
Collaborator Author

EbenSorkin commented Mar 22, 2024 via email

@emmamarichal
Copy link
Collaborator

Excellent, thank you!
Also, I just wanted to let you know that we have some concern with the new kerning that is much tighter than the old version and it create some regressions. We can see it especially in numbers. What do you think?
#7309 (comment)

@EbenSorkin
Copy link
Collaborator Author

EbenSorkin commented Mar 28, 2024 via email

@emmamarichal
Copy link
Collaborator

@chrissimpkins
STATUS: Eben will update the kerning next week, this will fix the regression we noticed.

@chrissimpkins
Copy link
Collaborator

Moving to Q2

@chrissimpkins chrissimpkins modified the milestones: 2024 Q1, 2024 Q2 Apr 1, 2024
@emmamarichal
Copy link
Collaborator

@EbenSorkin any updates about this?

@emmamarichal
Copy link
Collaborator

@chrissimpkins still blocked, the kerning needs to be updated, you can move it in Q3

@EbenSorkin
Copy link
Collaborator Author

EbenSorkin commented Jun 25, 2024 via email

@emmamarichal
Copy link
Collaborator

Actually, we like this new version, but we think it's a bit to tight indeed, and it causes regressions. Some layout on websites could be affected by such a big change

@chrissimpkins chrissimpkins modified the milestones: 2024 Q2, 2024 Q3 Jul 2, 2024
@emmamarichal
Copy link
Collaborator

@chrissimpkins Status: kerning still in progress

@chrissimpkins chrissimpkins modified the milestones: 2024 Q3, 2024 Q4 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II African Mostly west african non-latin and African indigenous scripts III Expand glyphset more features and more language coverage P3
Projects
Status: PR GF
6 participants