-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pacifico #7066
Comments
Hi @EbenSorkin and @Black-sage! @vv-monsalve noticed some tofu when she tested the font with the DinkaNuer text sample. #7104 (comment) I checked, and it seems that Gamma-latin and gamma-latin are missing ( Ɣ / ɣ -> U+0194 and U+0263). |
@emmamarichal @EbenSorkin |
Thanks, @Black-sage, for the clarification. @EbenSorkin, from the SSA sample texts in Octo-Text, could you provide us with a list of the ones covered by the Pri glyphset so that we can perform differentiated proofs. |
I can try to separate language samples between those relevant for pri and
ssa. The samples themselves came before the the pri and ssa definitions.
…-e.
On Thu, Jan 18, 2024 at 1:25 PM Viviana Monsalve ***@***.***> wrote:
Thanks, @Black-sage <https://github.com/Black-sage>, for the
clarification.
@EbenSorkin <https://github.com/EbenSorkin>, from the SSA sample texts in
Octo-Text, could you provide us with a list of the ones covered by the Pri
glyphset so that we can perform differentiated proofs.
—
Reply to this email directly, view it on GitHub
<#7066 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXNWFUZ3GRDFF3VN6VDYPFSHZAVCNFSM6AAAAABAI3RTSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYHE4TMMZYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @EbenSorkin and @Black-sage! @EbenSorkin, I made some tests with the sample you've made: https://github.com/SorkinType/octo-text/tree/main/Output/7%20African%20Language%20Textures I tested with
|
L᷊ and l᷊ are part of Pri now? |
@EbenSorkin |
I will look at the text samples next week and see how they need to be
adjusted to make them comply with contemporary definitions in the glyph
sets.
Part of the reason this might be complicated is that the CCMP made letters
result isn't in the nice name list so I need to mix both to really know.
I'm working on getting the updated mix now.
…On Fri, Mar 22, 2024 at 11:20 AM Emma Marichal ***@***.***> wrote:
@EbenSorkin <https://github.com/EbenSorkin>
Don't know, but they are in the tests you've made called "African Kern
Test Starting with GF African Pri Lc.txt"
If they are not, at least we should update or find appropriate sample text
to test Pri.
Do you know were are the more recents?
—
Reply to this email directly, view it on GitHub
<#7066 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXLNTOQRIPQOHULMK7TYZRD2VAVCNFSM6AAAAABAI3RTSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGMZDSMBQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Excellent, thank you! |
I think that the new treatment fits the overall spacing logic better but I
can also see an argument for continuity in which we let them stay as they
were - quite loose. I spoke to Dave about this but I don't recall either of
us feeling very strongly about it. That may be why we arrived at this.
If we did decide to change it back I wonder if the spacing was changed and
we added kerning too or if the change to spacing is the result of the auto
kerning.
In either case the solution will be the same if we want to adjust back to
the old spacing (or very nearly the same because we would now want some
kerning) I think I could treat the file next week.
…-e.
On Thu, Mar 28, 2024 at 6:09 AM Emma Marichal ***@***.***> wrote:
Excellent, thank you!
Also, I just wanted to let you know that we have some concern with the new
kerning that is much tighter than the old version and it create some
regressions. We can see it especially in numbers. What do you think?
#7309 (comment)
<#7309 (comment)>
—
Reply to this email directly, view it on GitHub
<#7066 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXIJP7R3QJWOKK5VAEDY2PM4PAVCNFSM6AAAAABAI3RTSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUHAZTGNJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@chrissimpkins |
Moving to Q2 |
@EbenSorkin any updates about this? |
@chrissimpkins still blocked, the kerning needs to be updated, you can move it in Q3 |
I had some open questions about what we want to do with this that I guess I
didn't get answered. It sounds like you want looser spacing than it got in
autokerning. I s that right? If so I could do the re-kern this week. I just
want to be clear about our intent before I put a few hours in.
…-e.
On Tue, Jun 25, 2024 at 6:07 AM Emma Marichal ***@***.***> wrote:
@chrissimpkins <https://github.com/chrissimpkins> still blocked, the
kerning needs to be updated, you can move it in Q3
—
Reply to this email directly, view it on GitHub
<#7066 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXNMI77ZYRBP7J4C7YLZJE6NJAVCNFSM6AAAAABAI3RTSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGQ4TSOBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Actually, we like this new version, but we think it's a bit to tight indeed, and it causes regressions. Some layout on websites could be affected by such a big change |
@chrissimpkins Status: kerning still in progress |
Font Project Git Repo URL: https://github.com/Black-sage/Pacifico
Current version: 3.00
New available version: 3.01
Super short description of the upgrade:
Expand glyphset to Africa Pri
Bugs reported in this repo which this upgrade would fix:
No issues in seen in repo.
**Notes: **
• This is an older repo and it lacks fontbakery checks and some documentation that is now standard.
• It may be that this branch should be merged with this one: https://github.com/Fonthausen/Pacifico IDK
• This font passes it's CCMP tests for PRI and even some SSA.
The text was updated successfully, but these errors were encountered: