Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anton SC has a ligature problem #8337

Closed
davelab6 opened this issue Oct 16, 2024 · 2 comments
Closed

Anton SC has a ligature problem #8337

davelab6 opened this issue Oct 16, 2024 · 2 comments
Assignees
Milestone

Comments

@davelab6
Copy link
Member

Describe the bug

Anton SC has an ff ligature problem where the conversion of lowercase to small caps mishandled the ligature, so a lowercase ligature is substituted over two small-scaps fs.

To Reproduce

https://fonts.google.com/specimen/Anton+SC?preview.text=Waffles%20WAFFLES

Expected behavior

No ligature

Screenshots

Image

@simoncozens might have insights

@simoncozens
Copy link
Collaborator

Looks like an issue with the order of lookups. The small cap rules are moved to the ccmp feature but they're in lookup 30; the liga feature is lookup 24. ccmp and liga are run in the same shaping "pause", so the rules are executed in order of lookup ID. This means the ligature happens first and the small caps afterwards. Our small-capifier should put the smcp rules into a fairly early lookup ID.

@emmamarichal emmamarichal added this to the Backlog milestone Oct 16, 2024
@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Oct 16, 2024

Repeated: This was reported by a user in #8331, in which Emma self-assigned her.

@github-project-automation github-project-automation bot moved this from Todo to In Dev / PR Merged in Google Fonts Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Dev / PR Merged
Development

No branches or pull requests

4 participants