Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Comment describing SetVLOGLevel is not accurate #858

@hari90

Description

@hari90

Currently the comment states the following:

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that have already executed after/during InitGoogleLogging,
//	 one needs to supply the exact --vmodule pattern that applied to them.
//       (If no --vmodule pattern applied to them
//       the value of FLAGS_v will continue to control them.)

But #650 added support for updating vmodule levels after vmodule level has been cached.

The comment should be

// NOTE: To change the log level for VLOG(_IS_ON) sites
//	 that matched a prior --vmodule pattern then the exact pattern has to be supplied again.
//       (If no --vmodule pattern applied to them before then the first matching pattern will start to control them.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions