Avoid private scope on writeReplace to be reachable for caller and be consistent overall

Author: Vincent Potucek

android/guava-testlib/src/com/google/common/testing/DummyProxy.java

@@ -129,7 +129,7 @@ public String toString() {
 
     // Since type variables aren't serializable, reduce the type down to raw type before
     // serialization.
-        private Object writeReplace() {
+        Object writeReplace() {
       return new DummyHandler(TypeToken.of(interfaceType.getRawType()));
     }
   }

android/guava-testlib/test/com/google/common/testing/SerializableTesterTest.java

@@ -103,7 +103,7 @@ public int hashCode() {
       return 1;
     }
 
-    private Object writeReplace() {
+    Object writeReplace() {
       return new OtherForm();
     }
 

android/guava/src/com/google/common/collect/MutableClassToInstanceMap.java

@@ -176,7 +176,7 @@ public void putAll(Map<? extends Class<? extends @NonNull B>, ? extends B> map)
     return Primitives.wrap(type).cast(value);
   }
 
-    private Object writeReplace() {
+    Object writeReplace() {
     return new SerializedForm<>(delegate());
   }
 

android/guava/src/com/google/common/hash/BloomFilter.java

@@ -544,7 +544,7 @@ static long optimalNumOfBits(long n, double p) {
     return (long) (-n * Math.log(p) / SQUARED_LOG_TWO);
   }
 
-    private Object writeReplace() {
+    Object writeReplace() {
     return new SerialForm<T>(this);
   }
 

guava-testlib/src/com/google/common/testing/DummyProxy.java

@@ -129,7 +129,7 @@ public String toString() {
 
     // Since type variables aren't serializable, reduce the type down to raw type before
     // serialization.
-        private Object writeReplace() {
+        Object writeReplace() {
       return new DummyHandler(TypeToken.of(interfaceType.getRawType()));
     }
   }

guava-testlib/test/com/google/common/testing/SerializableTesterTest.java

@@ -103,7 +103,7 @@ public int hashCode() {
       return 1;
     }
 
-    private Object writeReplace() {
+    Object writeReplace() {
       return new OtherForm();
     }
 

guava/src/com/google/common/collect/MutableClassToInstanceMap.java

@@ -183,7 +183,7 @@ public void putAll(Map<? extends Class<? extends @NonNull B>, ? extends B> map)
     return Primitives.wrap(type).cast(value);
   }
 
-    private Object writeReplace() {
+    Object writeReplace() {
     return new SerializedForm<>(delegate());
   }
 

guava/src/com/google/common/hash/BloomFilter.java

@@ -554,7 +554,7 @@ static long optimalNumOfBits(long n, double p) {
     return (long) (-n * Math.log(p) / SQUARED_LOG_TWO);
   }
 
-    private Object writeReplace() {
+    Object writeReplace() {
     return new SerialForm<T>(this);
   }
 

pom.xml

@@ -130,10 +130,42 @@
           </execution>
         </executions>
       </plugin>
+        <plugin>
+            <groupId>org.openrewrite.maven</groupId>
+            <artifactId>rewrite-maven-plugin</artifactId>
+      </plugin>
     </plugins>
     <pluginManagement>
       <plugins>
-        <plugin>
+          <plugin>
+              <groupId>org.openrewrite.maven</groupId>
+              <artifactId>rewrite-maven-plugin</artifactId>
+              <version>6.15.0</version>
+              <configuration>
+                  <activeRecipes>
+                      <recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>
+                      <recipe>org.openrewrite.staticanalysis.ModifierOrder</recipe>
+                  </activeRecipes>
+                  <exportDatatables>true</exportDatatables>
+                  <failOnDryRunResults>true</failOnDryRunResults>
+              </configuration>
+              <executions>
+                  <execution>
+                      <phase>verify</phase>
+                      <goals>
+                          <goal>dryRun</goal>
+                      </goals>
+                  </execution>
+              </executions>
+              <dependencies>
+                  <dependency>
+                      <groupId>org.openrewrite.recipe</groupId>
+                      <artifactId>rewrite-static-analysis</artifactId>
+                      <version>2.14.0</version>
+                  </dependency>
+              </dependencies>
+          </plugin>
+          <plugin>
           <artifactId>maven-antrun-plugin</artifactId>
           <version>1.6</version>
         </plugin>