Add rewrite support for staticanalysis.RemoveUnused and maven.BestPractices

Author: Vincent Potucek

.github/workflows/ci.yml

@@ -51,10 +51,16 @@ jobs:
           cache: 'maven'
       - name: 'Install'
         shell: bash
-        run: ./mvnw -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dtoolchain.skip install -U -DskipTests=true -f $ROOT_POM
+        run: ./mvnw -DrewriteSkip=true -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dtoolchain.skip install -U -DskipTests=true -f $ROOT_POM
       - name: 'Test'
         shell: bash
-        run: ./mvnw -B -P!standard-with-extra-repos -Dtoolchain.skip verify -U -Dmaven.javadoc.skip=true -Dsurefire.toolchain.version=${{ matrix.java }} -f $ROOT_POM
+        run: ./mvnw -DrewriteSkip=true -B -P!standard-with-extra-repos -Dtoolchain.skip verify -U -Dmaven.javadoc.skip=true -Dsurefire.toolchain.version=${{ matrix.java }} -f $ROOT_POM
+#     Apple M2 (4E+4P+10GPU 8GB)
+#     Total time:  44.504 s
+#     TODO: consider switch invert, executing on CI only (if acceptable build time).
+#      - name: 'Rewrite'
+#        shell: bash
+#        run: ./mvnw rewrite:dryRun -B -P!standard-with-extra-repos -Dtoolchain.skip -U -Dmaven.javadoc.skip=true -Dsurefire.toolchain.version=${{ matrix.java }} -f $ROOT_POM
       - name: 'Print Surefire reports'
         # Note: Normally a step won't run if the job has failed, but this causes it to
         if: ${{ failure() }}

android/guava-testlib/src/com/google/common/escape/testing/package-info.java

@@ -22,5 +22,3 @@
  */
 @CheckReturnValue
 package com.google.common.escape.testing;
-
-import com.google.errorprone.annotations.CheckReturnValue;

android/guava-testlib/src/com/google/common/testing/package-info.java

@@ -21,6 +21,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.testing;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/base/package-info.java

@@ -59,6 +59,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.base;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/cache/package-info.java

@@ -31,6 +31,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.cache;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/collect/package-info.java

@@ -122,6 +122,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.collect;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/escape/package-info.java

@@ -27,6 +27,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.escape;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/eventbus/package-info.java

@@ -22,6 +22,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.eventbus;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/graph/package-info.java

@@ -24,6 +24,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.graph;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;

android/guava/src/com/google/common/hash/package-info.java

@@ -22,6 +22,3 @@
 @CheckReturnValue
 @NullMarked
 package com.google.common.hash;
-
-import com.google.errorprone.annotations.CheckReturnValue;
-import org.jspecify.annotations.NullMarked;