Skip to content

Commit d43da09

Browse files
committed
fix broken tests
1 parent 4675585 commit d43da09

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

core/camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import androidx.test.rule.GrantPermissionRule
2828
import com.google.jetpackcamera.core.camera.OnVideoRecordEvent.OnVideoRecordError
2929
import com.google.jetpackcamera.core.camera.OnVideoRecordEvent.OnVideoRecorded
3030
import com.google.jetpackcamera.core.camera.utils.APP_REQUIRED_PERMISSIONS
31+
import com.google.jetpackcamera.core.common.FakeFilePathGenerator
3132
import com.google.jetpackcamera.model.FlashMode
3233
import com.google.jetpackcamera.model.Illuminant
3334
import com.google.jetpackcamera.model.LensFacing
@@ -169,7 +170,8 @@ class CameraXCameraSystemTest {
169170
iODispatcher = Dispatchers.IO,
170171
constraintsRepository = constraintsRepository,
171172
availabilityCheckers = emptyMap(),
172-
effectProviders = emptyMap()
173+
effectProviders = emptyMap(),
174+
filePathGenerator = FakeFilePathGenerator()
173175
).apply {
174176
initialize(appSettings) {}
175177
providePreviewSurface()

data/media/src/test/java/com/google/jetpackcamera/media/FakeFilePathGenerator.kt renamed to core/common/src/main/java/com/google/jetpackcamera/core/common/FakeFilePathGenerator.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,9 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package com.google.jetpackcamera.media
16+
package com.google.jetpackcamera.core.common
1717

1818
import android.os.Environment
19-
import com.google.jetpackcamera.core.common.FilePathGenerator
2019
import java.io.File
2120
import java.util.Date
2221

data/media/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ dependencies {
9090

9191
// Project dependencies
9292
implementation(project(":core:common"))
93+
testImplementation(project(":core:common"))
94+
9395
}
9496

9597
// Allow references to generated code

data/media/src/main/kotlin/com/google/jetpackcamera/data/media/LocalMediaRepository.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,6 @@ class LocalMediaRepository
316316
): Uri? {
317317
val contentResolver = context.contentResolver
318318
val destinationUri: Uri?
319-
println(fileOutputDirectory)
320319

321320
val contentValues = ContentValues().apply {
322321
put(MediaStore.MediaColumns.DISPLAY_NAME, outputFilename)

data/media/src/test/java/com/google/jetpackcamera/media/LocalMediaRepositoryTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import android.net.Uri
2424
import android.os.Build
2525
import android.provider.MediaStore
2626
import androidx.test.core.app.ApplicationProvider
27+
import com.google.jetpackcamera.core.common.FakeFilePathGenerator
2728
import com.google.jetpackcamera.data.media.LocalMediaRepository
2829
import com.google.jetpackcamera.data.media.Media
2930
import com.google.jetpackcamera.data.media.MediaDescriptor

0 commit comments

Comments
 (0)