Skip to content

Incorrect package name in uistateadapter Utils.kt #423

@helpingstar

Description

@helpingstar

Issue

I noticed that Utils.kt in the uistateadapter module is using an incorrect package name.

Location: ui/uistateadapter/src/main/java/com/example/uistateadapter/Utils.kt

package com.example.uistateadapter
import com.google.jetpackcamera.ui.uistate.SingleSelectableUiState
object Utils {
/**
* @param supportedValues a [Set] of options that are selectable in the current device configuration
* @param sortedValues a [List] of sorted options that always contains [supportedValues].
* @return a new List of [SingleSelectableUiState.SelectableUi] that contains all [supportedValues] ordered in accordance to [sortedValues]
* */
fun <T> getSelectableListFromValues(
valueSet: Set<T>,
filteringList: List<T>
): List<SingleSelectableUiState<T>> {
return filteringList.filter {
it in valueSet
}.map { value ->
SingleSelectableUiState.SelectableUi(value)
}
}
}

The file currently uses com.example.uistateadapter as its package, while all other files in the project follow the com.google.jetpackcamera.* naming convention.

Details

Files affected by this import:

  • AspectRatioUiStateAdapter.kt
  • FlashModeUiStateAdapter.kt
  • FlipLensUiStateAdapter.kt
  • StreamConfigsUiStateAdapter.kt

It appears the package should be com.google.jetpackcamera.ui.uistateadapter to maintain consistency with the project structure.

If this is indeed a mistake, I'd be happy to submit a PR to fix it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions