Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParsePartialFromString error not handled in mutator.cc #205

Open
vabr-g opened this issue May 10, 2022 · 1 comment
Open

ParsePartialFromString error not handled in mutator.cc #205

vabr-g opened this issue May 10, 2022 · 1 comment

Comments

@vabr-g
Copy link

vabr-g commented May 10, 2022

In

message->ParsePartialFromString(std::string(any.value()));
, the Boolean result of ParsePartialFromString is not handled (by returning null).

This seems like an oversight.

But OTOH, it just allowed us to catch a bug in the proto parser library. So maybe it's on purpose?

Filing this in any case, so that the libprotobuf-mutator maintainers can decide.

@vitalybuka
Copy link
Collaborator

It's intentionally resilient to parsing error to avoid getting corpus obsolete if proto changed
If some required fields are missing, Mutate will try populate them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants