remove unused functions and fix static analysis warnings

Author: drinckes

go/decode.go

@@ -90,7 +90,7 @@ func Decode(code string) (CodeArea, error) {
 	// Everything is ints so they all need to be cast to floats.
 	lat := float64(normalLat)/pairPrecision + float64(extraLat)/finalLatPrecision
 	lng := float64(normalLng)/pairPrecision + float64(extraLng)/finalLngPrecision
-	// Round everthing off to 14 places.
+	// Round everything off to 14 places.
 	return CodeArea{
 		LatLo: math.Round(lat*1e14) / 1e14,
 		LngLo: math.Round(lng*1e14) / 1e14,

go/encode.go

@@ -27,10 +27,6 @@ var (
 	ErrNotShort = errors.New("not short code")
 )
 
-const (
-	minTrimmableCodeLen = 6
-)
-
 // Encode a location into an Open Location Code.
 //
 // Produces a code of the specified codeLen, or the default length if
@@ -106,8 +102,8 @@ func Encode(lat, lng float64, codeLen int) string {
 	code[3], lngVal = pairIndexStep(lngVal)
 	code[2], latVal = pairIndexStep(latVal)
 
-	code[1], lngVal = pairIndexStep(lngVal)
-	code[0], latVal = pairIndexStep(latVal)
+	code[1], _ = pairIndexStep(lngVal)
+	code[0], _ = pairIndexStep(latVal)
 
 	// If we don't need to pad the code, return the requested section.
 	if codeLen >= sepPos {
@@ -117,23 +113,6 @@ func Encode(lat, lng float64, codeLen int) string {
 	return string(code[:codeLen]) + strings.Repeat(string(Padding), sepPos-codeLen) + string(Separator)
 }
 
-// roundLatLngToInts rounds the passed latitude and longitude to integral values
-// representing a location within 1 centimetre of the passed coordinates.
-func roundLatLngToInts(lat, lng float64) (int64, int64) {
-	// To round, we:
-	// 1) Offset latitude and longitude so that all values are positive.
-	// 2) Multiply by the final precision before conversion to integer to preserve precision.
-	// 3) Multiply by desired rounding precision and add 1.
-	// 4) Bit shift to undo the multiply used for rounding.
-
-	// Precision of rounding is equal to 2^roundPrecision.
-	// A value of 20 corresponds to sub-centimetre precision.
-	const roundPrecision = 20
-	latVal := int64((lat+latMax)*finalLatPrecision*(1<<roundPrecision)+1) >> roundPrecision
-	lngVal := int64((lng+lngMax)*finalLngPrecision*(1<<roundPrecision)+1) >> roundPrecision
-	return latVal, lngVal
-}
-
 // clipCodeLen returns the smallest valid code length greater than or equal to
 // the desired code length.
 func clipCodeLen(codeLen int) int {
@@ -167,14 +146,3 @@ func pairIndexStep(coordinate int64) (byte, int64) {
 	latNdx := coordinate % int64(encBase)
 	return Alphabet[latNdx], coordinate
 }
-
-// computeLatPrec computes the precision value for a given code length.
-// Lengths <= 10 have the same precision for latitude and longitude,
-// but lengths > 10 have different precisions due to the grid method
-// having fewer columns than rows.
-func computeLatPrec(codeLen int) float64 {
-	if codeLen <= pairCodeLen {
-		return math.Pow(float64(encBase), math.Floor(float64(codeLen/-2+2)))
-	}
-	return math.Pow(float64(encBase), -3) / math.Pow(float64(gridRows), float64(codeLen-pairCodeLen))
-}

go/olc.go

@@ -231,10 +231,6 @@ func clipLatitude(lat float64) float64 {
 	return lat
 }
 
-func normalizeLat(value float64) float64 {
-	return normalize(value, latMax)
-}
-
 func normalizeLng(value float64) float64 {
 	return normalize(value, lngMax)
 }

go/olc_test.go

@@ -47,9 +47,9 @@ type (
 	}
 
 	decodingTest struct {
-		code                                 string
-		length                               int
-		lat, lng, latLo, lngLo, latHi, lngHi float64
+		code                       string
+		length                     int
+		latLo, lngLo, latHi, lngHi float64
 	}
 
 	shortenTest struct {
@@ -78,9 +78,7 @@ func init() {
 
 	go func() {
 		defer wg.Done()
-		for _, cols := range append(
-			mustReadLines("encoding.csv"),
-		) {
+		for _, cols := range mustReadLines("encoding.csv") {
 			encoding = append(encoding, encodingTest{
 				lat:    mustFloat(cols[0]),
 				lng:    mustFloat(cols[1]),
@@ -92,9 +90,7 @@ func init() {
 
 	go func() {
 		defer wg.Done()
-		for _, cols := range append(
-			mustReadLines("decoding.csv"),
-		) {
+		for _, cols := range mustReadLines("decoding.csv") {
 			decoding = append(decoding, decodingTest{
 				code:   cols[0],
 				length: mustInt(cols[1]),