Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window10 bootstrap-orbit.ps1 have a little problem with conan version check part #4791

Open
jangddol opened this issue Feb 1, 2023 · 1 comment

Comments

@jangddol
Copy link

jangddol commented Feb 1, 2023

On 44 line of ./bootstrap-orbit.ps1,

  if (!Check-Conan-Version-Sufficient $conan_version $conan_version_required) {
      ^
      |
not compiled well.

Since my computer language setting is not English, the error message may not be shown.

I fixed the above problem as:

  if (!(Check-Conan-Version-Sufficient $conan_version $conan_version_required)) {

Thank you.

@jangddol jangddol changed the title Window10 build.ps1 have a little problem with conan version check part Window10 bootstrap-orbit.ps1 have a little problem with conan version check part Feb 1, 2023
@beckerhe
Copy link
Collaborator

beckerhe commented Feb 1, 2023

Hi jangddol,
thank you for your contribution! Could you put that into a pull request, so that we can merge that? That would be great.

Thank you,
Henning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants