We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the recent large scale experiment some projects got a wrong benchmark target: #618
We could have discovered this doing some form of sanity check in the source code at some stage.
The sample is e.g. hiredis where the benchmarks has:
hiredis
... "target_name": "format_command_fuzzer" "target_path": "/src/hiredis/format_command_fuzzer.c" "test_files": - "test_file_path": "/src/hiredis/examples/example-ssl.c" ...
However, because the harness is moved around in build.sh we ended up flagging two possible harness candidates and overwrote the destination of the copy, meaning our harness would not be in the source code: https://github.com/google/oss-fuzz/blob/bf53d7f396930655fa3db2a9b89b7cab9a543b25/projects/hiredis/build.sh#L19
build.sh
We can do a couple of things:
The text was updated successfully, but these errors were encountered:
hiredis: avoid mv in build
44df528
Ref: google/oss-fuzz-gen#635 Signed-off-by: David Korczynski <[email protected]>
hiredis: avoid mv in build (#12521)
e7e7907
DavidKorczynski
No branches or pull requests
In the recent large scale experiment some projects got a wrong benchmark target: #618
We could have discovered this doing some form of sanity check in the source code at some stage.
The sample is e.g.
hiredis
where the benchmarks has:However, because the harness is moved around in
build.sh
we ended up flagging two possible harness candidates and overwrote the destination of the copy, meaning our harness would not be in the source code: https://github.com/google/oss-fuzz/blob/bf53d7f396930655fa3db2a9b89b7cab9a543b25/projects/hiredis/build.sh#L19We can do a couple of things:
The text was updated successfully, but these errors were encountered: