Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity check harnesses in the coverage reports and/or builds #635

Open
DavidKorczynski opened this issue Sep 20, 2024 · 0 comments
Open
Assignees

Comments

@DavidKorczynski
Copy link
Collaborator

In the recent large scale experiment some projects got a wrong benchmark target: #618

We could have discovered this doing some form of sanity check in the source code at some stage.

The sample is e.g. hiredis where the benchmarks has:

...
"target_name": "format_command_fuzzer"
"target_path": "/src/hiredis/format_command_fuzzer.c"
"test_files":
- "test_file_path": "/src/hiredis/examples/example-ssl.c"
...

However, because the harness is moved around in build.sh we ended up flagging two possible harness candidates and overwrote the destination of the copy, meaning our harness would not be in the source code: https://github.com/google/oss-fuzz/blob/bf53d7f396930655fa3db2a9b89b7cab9a543b25/projects/hiredis/build.sh#L19

We can do a couple of things:

  • better harness target detection. We can probably add some heuristics here.
  • sanity check
@DavidKorczynski DavidKorczynski self-assigned this Sep 20, 2024
DavidKorczynski added a commit to google/oss-fuzz that referenced this issue Sep 20, 2024
AdamKorcz pushed a commit to google/oss-fuzz that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant