Fix benchmark status reporting to accurately reflect trial completion #847
+33
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modified the benchmark status determination logic in
common.py
to:_get_expected_trials_count()
that scans benchmark directories to determine the total expected number of trialsmatch_benchmark()
to mark benchmarks as "Done" only when all expected trials are completeTesting
Tested the solution by creating benchmarks in various states using a local script:
Verified the status was correctly reported as "Running" for partial and failed benchmarks, and "Done" only for the complete benchmark
Fixes #721