Skip to content

Incorrect colour display logic #849

Closed
@myanvoos

Description

@myanvoos

From this issue, it's intended that if the value in the Builds column is True then render the text as 'green', and if the value in the Crashes or Bug columns is False then render their text as 'red'. However the current display logic isn't reflecting this.

Currently:

<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
        <td style="color: {{ 'red' if sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
        <td style="color: {{ 'red' if sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>

Image

This should be instead

<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
        <td style="color: {{ 'red' if not sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
        <td style="color: {{ 'red' if not sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>

Image

I'll submit a PR fixing it very shortly, and also resolving #233

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions