Closed
Description
From this issue, it's intended that if the value in the Builds
column is True
then render the text as 'green', and if the value in the Crashes
or Bug
columns is False
then render their text as 'red'. However the current display logic isn't reflecting this.
Currently:
<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
<td style="color: {{ 'red' if sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
<td style="color: {{ 'red' if sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>
This should be instead
<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
<td style="color: {{ 'red' if not sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
<td style="color: {{ 'red' if not sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>
I'll submit a PR fixing it very shortly, and also resolving #233
Metadata
Metadata
Assignees
Labels
No labels