Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect colour display logic #849

Open
myanvoos opened this issue Mar 11, 2025 · 0 comments
Open

Incorrect colour display logic #849

myanvoos opened this issue Mar 11, 2025 · 0 comments

Comments

@myanvoos
Copy link

myanvoos commented Mar 11, 2025

From this issue, it's intended that if the value in the Builds column is True then render the text as 'green', and if the value in the Crashes or Bug columns is False then render their text as 'red'. However the current display logic isn't reflecting this.

Currently:

<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
        <td style="color: {{ 'red' if sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
        <td style="color: {{ 'red' if sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>

Image

This should be instead

<td style="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td>
        <td style="color: {{ 'red' if not sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td>
        <td style="color: {{ 'red' if not sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>

Image

I'll submit a PR fixing it very shortly, and also resolving #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant