You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From this issue, it's intended that if the value in the Builds column is True then render the text as 'green', and if the value in the Crashes or Bug columns is False then render their text as 'red'. However the current display logic isn't reflecting this.
Currently:
<tdstyle="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td><tdstyle="color: {{ 'red' if sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td><tdstyle="color: {{ 'red' if sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>
This should be instead
<tdstyle="color: {{ 'green' if sample.result.compiles else 'black' }}">{{ sample.result.compiles }}</td><tdstyle="color: {{ 'red' if not sample.result.crashes else 'black' }}">{{ sample.result.crashes }}</td><tdstyle="color: {{ 'red' if not sample.result.crashes and not sample.result.is_semantic_error else 'black' }}">{{ sample.result.crashes and not sample.result.is_semantic_error }}</td>
I'll submit a PR fixing it very shortly, and also resolving #233
The text was updated successfully, but these errors were encountered:
From this issue, it's intended that if the value in the
Builds
column isTrue
then render the text as 'green', and if the value in theCrashes
orBug
columns isFalse
then render their text as 'red'. However the current display logic isn't reflecting this.Currently:
This should be instead
I'll submit a PR fixing it very shortly, and also resolving #233
The text was updated successfully, but these errors were encountered: