Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request][UI] Improve naming in "Area selection" tab for power samples for better UX #910

Open
cphlipot1 opened this issue Oct 18, 2024 · 1 comment

Comments

@cphlipot1
Copy link
Contributor

cphlipot1 commented Oct 18, 2024

If i click and drag over power samples in the UI i see something that gives something that looks like the following:

Image

I think there is a lot of useful data in that tab, but it is difficult for many users to decipher who don't already have an understanding of Perfetto internals relating to how the samples are stored and processed internally. To improve UX i suggest renaming some columns and removing others in the selection window to improve UX as follows:

  • "Name" -> "Power Rail"
  • "Delta value" -> "Energy (uJ)" or "Energy (uWS)"
  • "Rate /s" -> "Avg Power (uW)"
  • "Weighted avg value" -> (Remove this. it isn't really clear the applicability of averaging energy samples and due to the name may people misinterpret this as the average power instead of average energy)
  • "Count" - > "Number of Samples"
  • "First Value" -> (Remove this)
  • "Last Value" -> (Remove this)
  • "Min Value" -> (Remove this)
  • "Max Value" -> (Remove this)
@LalitMaganti
Copy link
Collaborator

Yeah I think what is going on here is that you are seeing the generic view for aggregating any "counter like" data there, irrespective of the source etc.

We're in the process of totally rewriting area selection and I think customizing the information in the generic area selection (and/or adding custom area selection for things we care a lot about) makes a lot of sense.

@stevegolton FYI feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants