Add support for specifying api version #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirvala08
requested changes
Nov 28, 2025
Collaborator
mihirvala08
left a comment
mihirvala08
left a comment
There was a problem hiding this comment.
Approach looks fine. Just some minor things to go over.
mihirvala08
reviewed
Nov 28, 2025
Collaborator
|
@TimDiam0nd Would it possible to provide me write access to forked branch hisn-io:main ? I've updated linting, tests and |
Contributor
Author
Done |
Collaborator
|
/run-integration-tests cc2f4c0 |
Collaborator
|
/run-integration-tests cc7fd7b |
Collaborator
|
/run-integration-tests 704224b |
mihirvala08
approved these changes
Dec 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #143 (apologies for the delay in this, it slipped my mind).
This approach with a custom class allows the existing usage to remain the same, allows specifying a client level preference, overriding on a per func level, and defining the supported APIs.
If youre happy with this approach, i can make a start on removing references to
base_v1_url.