Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit declarative_friendly annotations #1204

Open
toumorokoshi opened this issue Jul 19, 2023 · 1 comment
Open

audit declarative_friendly annotations #1204

toumorokoshi opened this issue Jul 19, 2023 · 1 comment
Assignees
@toumorokoshi
Labels
priority: p3 type: feature request

Comments

@toumorokoshi
Copy link
Contributor

we should audit all usages of the declarative_friendly annotation. These usages may no longer be accurate (e.g. with soft-delete no longer required for declarative).
@toumorokoshi toumorokoshi self-assigned this Jul 19, 2023
@toumorokoshi
Copy link
Contributor Author

mechanically, this is just auditing rules that call utils.IsDeclarativeFriendlyMethod(m), seeing what branches, and then adjusting them.

the annotation should not be necessary in the future, as declarative friendly is merging with the AIPs themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toumorokoshi toumorokoshi

Labels
priority: p3 type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toumorokoshi