Skip to content

Commit bacb352

Browse files
committed
revert sync grpc file
1 parent 503b041 commit bacb352

File tree

1 file changed

+15
-23
lines changed
  • gapic/templates/%namespace/%name_%version/%sub/services/%service/transports

1 file changed

+15
-23
lines changed

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
{% block content %}
44

5-
import json
65
import logging as std_logging
76
import warnings
87
from typing import Callable, Dict, Optional, Sequence, Tuple, Union
@@ -45,9 +44,6 @@ from google.longrunning import operations_pb2 # type: ignore
4544
{% endfilter %}
4645
from .base import {{ service.name }}Transport, DEFAULT_CLIENT_INFO
4746

48-
import proto
49-
import google.protobuf.message
50-
5147
try:
5248
from google.api_core import client_logging # type: ignore
5349
CLIENT_LOGGING_SUPPORTED = True # pragma: NO COVER
@@ -59,11 +55,11 @@ _LOGGER = std_logging.getLogger(__name__)
5955

6056
class _LoggingClientInterceptor(grpc.UnaryUnaryClientInterceptor): # pragma: NO COVER
6157
def intercept_unary_unary(self, continuation, client_call_details, request):
62-
request_metadata = client_call_details.metadata
63-
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(std_logging.DEBUG):
64-
if isinstance(request, proto.Message):
58+
if CLIENT_LOGGING_SUPPORTED and not _LOGGER.isEnabledFor(std_logging.NOTSET): # pragma: NO COVER
59+
request_metadata = client_call_details.metadata
60+
try:
6561
request_payload = type(request).to_json(request)
66-
elif isinstance(request, google.protobuf.message.Message):
62+
except:
6763
request_payload = MessageToJson(request)
6864
grpc_request = {
6965
"payload": request_payload,
@@ -76,37 +72,33 @@ class _LoggingClientInterceptor(grpc.UnaryUnaryClientInterceptor): # pragma: NO
7672
"serviceName": "{{ service.meta.address.proto }}",
7773
"rpcName": client_call_details.method,
7874
"request": grpc_request,
79-
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up. We're including it within "request" for consistency with REST transport.' #}
75+
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up. We're including it within "request" for consistency with REST transport. #}
8076
"metadata": grpc_request["metadata"],
8177
},
8278
)
8379

8480
response = continuation(client_call_details, request)
85-
response_metadata = response.trailing_metadata()
86-
# Convert gRPC metadata `<class 'grpc.aio._metadata.Metadata'>` to list of tuples
87-
metadata = dict([(k, v) for k, v in response_metadata]) if response_metadata else None
88-
result = response.result()
89-
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(std_logging.DEBUG): # pragma: NO COVER
90-
if isinstance(result, proto.Message):
81+
if CLIENT_LOGGING_SUPPORTED and not _LOGGER.isEnabledFor(std_logging.NOTSET): # pragma: NO COVER
82+
response_metadata = response.trailing_metadata()
83+
# Convert gRPC metadata `<class 'grpc.aio._metadata.Metadata'>` to list of tuples
84+
metadata = dict([(k, v) for k, v in response_metadata]) if response_metadata else None
85+
result = response.result()
86+
try:
9187
response_payload = type(result).to_json(result)
92-
elif isinstance(result, google.protobuf.message.Message):
88+
except:
9389
response_payload = MessageToJson(result)
94-
else:
95-
if isinstance(result, bytes):
96-
result = result.decode('utf-8')
97-
response_payload = json.dumps(result)
9890
grpc_response = {
9991
"payload": response_payload,
10092
"metadata": metadata,
101-
"status": "OK",
93+
"status": "OK",
10294
}
10395
_LOGGER.debug(
10496
f"Received response for {client_call_details.method}.",
10597
extra = {
10698
"serviceName": "{{ service.meta.address.proto }}",
10799
"rpcName": client_call_details.method,
108100
"response": grpc_response,
109-
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up. We're including it within "request" for consistency with REST transport.' #}
101+
{# TODO(https://github.com/googleapis/gapic-generator-python/issues/2275): logging `metadata` seems repetitive and may need to be cleaned up. We're including it within "request" for consistency with REST transport. #}
110102
"metadata": grpc_response["metadata"],
111103
},
112104
)
@@ -266,7 +258,7 @@ class {{ service.name }}GrpcTransport({{ service.name }}Transport):
266258
)
267259

268260
self._grpc_channel = self._base_channel
269-
if CLIENT_LOGGING_SUPPORTED and _LOGGER.isEnabledFor(std_logging.DEBUG): # pragma: NO COVER
261+
if CLIENT_LOGGING_SUPPORTED and not _LOGGER.isEnabledFor(std_logging.NOTSET): # pragma: NO COVER
270262
self._interceptor = _LoggingClientInterceptor()
271263
self._grpc_channel = grpc.intercept_channel(self._base_channel, self._interceptor)
272264

0 commit comments

Comments
 (0)