Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve lint issues when running flake8 #2333

Open
parthea opened this issue Feb 14, 2025 · 1 comment
Open

Resolve lint issues when running flake8 #2333

parthea opened this issue Feb 14, 2025 · 1 comment
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@parthea
Copy link
Contributor

parthea commented Feb 14, 2025

There are several failures when running flake8. This tracking bug was created as a follow up to ensure that all lint issues are addressed.

# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E123, E124
# Closing bracket mismatches opening bracket's line.
# This works poorly with type annotations in method declarations.
E123, E124
# Line over-indented for visual indent.
# This works poorly with type annotations in method declarations.
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E126, E128, E131
E126, E128, E131
# Line break after binary operator.
# This catches line breaks after "and" / "or" as a means of breaking up
# long if statements, which PEP 8 explicitly encourages.
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): W504
W504
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E203
E203
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E501
E501
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E712
E712
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E711
E711
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E722
E722
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): E741
E741
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): F401
F401
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): F541
F541
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): F841
F841
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): F811
F811
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): W503
W503
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2333): W291
W291

@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label Feb 14, 2025
@parthea
Copy link
Contributor Author

parthea commented Apr 9, 2025

Also see these lines where we're excluding linting on generated code

**/gapic/**
**/services/**
**/types/**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants