cleanup(compute/v1): prefer to_result() for errors (#3601)

Author: coryan

guide/samples/src/compute.rs

@@ -60,14 +60,18 @@ pub async fn cleanup_stale_instances(client: &Instances, project_id: &str) -> an
             }
             if let (Some(name), Some(zone)) = (instance.name, instance.zone) {
                 println!("Deleting VM {name} in zone {zone}");
-                let _ = client
+                let result = client
                     .delete()
                     .set_project(project_id)
                     .set_zone(zone)
                     .set_instance(name)
                     .poller()
                     .until_done()
-                    .await?;
+                    .await;
+                match result {
+                    Err(e) => println!("operation did not complete, error={e:?}"),
+                    Ok(op) => println!("operation completed with {:?}", op.to_result()),
+                };
             }
         }
     }

guide/samples/src/compute/compute_instances_create.rs

@@ -43,7 +43,8 @@ pub async fn sample(client: &Instances, project_id: &str, name: &str) -> anyhow:
         .set_body(instance)
         .poller()
         .until_done()
-        .await?;
+        .await?
+        .to_result()?;
     println!("Instance successfully created: {operation:?}");
 
     Ok(())

guide/samples/src/compute/compute_instances_delete.rs

@@ -26,7 +26,8 @@ pub async fn sample(client: &Instances, project_id: &str, name: &str) -> anyhow:
         .set_instance(name)
         .poller()
         .until_done()
-        .await?;
+        .await?
+        .to_result()?;
     println!("Instance successfully deleted: {operation:?}");
 
     Ok(())

guide/samples/src/compute/compute_instances_operation_check.rs

@@ -48,7 +48,7 @@ pub async fn sample(client: &Instances, project_id: &str, name: &str) -> anyhow:
 
     println!("Instance creation finished: {operation:?}");
     // Check if there was an error.
-    if let Some(error) = &operation.error {
+    if let Err(error) = operation.to_result() {
         println!("Instance creation failed: {error:?}");
         return Err(anyhow::Error::msg(format!(
             "instance creation failed with: {error:?}"

guide/samples/src/compute/compute_usage_report_set.rs

@@ -39,7 +39,8 @@ pub async fn sample(client: &Projects, project_id: &str, bucket_name: &str) -> a
         )
         .poller()
         .until_done()
-        .await?;
+        .await?
+        .to_result()?;
     println!("Setting the usage export bucket completed successfully: {operation:?}");
 
     Ok(())