-
Notifications
You must be signed in to change notification settings - Fork 116
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Description
I have introduced some inconsistency in attribute names and values for the different signals (more or less intentionally, I wanted to see all the signals working, even if not "perfect"). Including:
- For most services spans, the
rpc.methodshould be the name of the gRPC method, as ingoogle.cloud.secretmanager.v1.SecretManager/CreateSecret - For storage, the
rpc.methodshould be the - Errors should include the
error.typefield - Traces and errors should not include
rpc.service(rpc.methodcarries this) - The
rpc.systemkey should be replaced withrpc.system.name(same values) - The
gcp.resource.namekey should be replaced withgcp.resource.destination.id(same values) - The
gcp.client.*keys should be present on metrics - Include the the Schema URL is spans and metrics.
- It should be set to"https://opentelemetry.io/schemas/1.39.0"on the instrumentation scope
- Where this is not possible (because tracing_opentelemetry doesn't support it) we can omit it, or
- Put it in an attributegcp.schema.url
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.