-
Notifications
You must be signed in to change notification settings - Fork 129
deps: update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deps: update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 #3994
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency upgrade, specifically updating the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the com.google.cloud:sdk-platform-java-config dependency from version 3.53.0 to 3.54.0. The version is updated in the parent pom.xml files and also in several Kokoro CI configuration files. While the changes are correct for the update, I've noticed that the dependency version is hardcoded in six different Kokoro configuration files. I've left a comment suggesting to centralize this version to improve maintainability and avoid potential inconsistencies in the future. Otherwise, the changes look good.
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.53.0" | ||
| value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.54.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for sdk-platform-java-config is hardcoded here and in 5 other Kokoro configuration files (.kokoro/continuous/graalvm-native-b.cfg, .kokoro/continuous/graalvm-native-c.cfg, .kokoro/presubmit/graalvm-native-a.cfg, .kokoro/presubmit/graalvm-native-b.cfg, .kokoro/presubmit/graalvm-native-c.cfg). This duplication makes version updates tedious and error-prone. To improve maintainability, consider centralizing this version number. For example, you could define it in a single script or configuration file that is sourced by all related CI jobs. This would ensure consistency and simplify future updates.
2d09f54 to
c860650
Compare
|
/gcbrun |
c860650 to
8471c42
Compare
|
/gcbrun |
This PR contains the following updates:
3.53.0->3.54.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.