Skip to content

Commit 97f4544

Browse files
sagarwaalSagar Agarwal
and
Sagar Agarwal
authored
fix: add default implementations for Interval methods in AbstractStructReader (#3722)
* fix: Provide default implementations for Interval methods in AbstractStructReader * addressed PR comments --------- Co-authored-by: Sagar Agarwal <[email protected]>
1 parent b382999 commit 97f4544

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

google-cloud-spanner/clirr-ignored-differences.xml

-10
Original file line numberDiff line numberDiff line change
@@ -597,16 +597,6 @@
597597
<className>com/google/cloud/spanner/StructReader</className>
598598
<method>java.util.List getIntervalList(java.lang.String)</method>
599599
</difference>
600-
<difference>
601-
<differenceType>7013</differenceType>
602-
<className>com/google/cloud/spanner/AbstractStructReader</className>
603-
<method>com.google.cloud.spanner.Interval getIntervalInternal(int)</method>
604-
</difference>
605-
<difference>
606-
<differenceType>7013</differenceType>
607-
<className>com/google/cloud/spanner/AbstractStructReader</className>
608-
<method>java.util.List getIntervalListInternal(int)</method>
609-
</difference>
610600
<difference>
611601
<differenceType>7013</differenceType>
612602
<className>com/google/cloud/spanner/Value</className>

google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ protected String getPgJsonbInternal(int columnIndex) {
6767

6868
protected abstract Date getDateInternal(int columnIndex);
6969

70-
protected abstract Interval getIntervalInternal(int columnIndex);
70+
protected Interval getIntervalInternal(int columnIndex) {
71+
throw new UnsupportedOperationException("Not implemented");
72+
}
7173

7274
protected <T extends AbstractMessage> T getProtoMessageInternal(int columnIndex, T message) {
7375
throw new UnsupportedOperationException("Not implemented");
@@ -130,7 +132,9 @@ protected List<String> getPgJsonbListInternal(int columnIndex) {
130132

131133
protected abstract List<Date> getDateListInternal(int columnIndex);
132134

133-
protected abstract List<Interval> getIntervalListInternal(int columnIndex);
135+
protected List<Interval> getIntervalListInternal(int columnIndex) {
136+
throw new UnsupportedOperationException("Not implemented");
137+
}
134138

135139
protected abstract List<Struct> getStructListInternal(int columnIndex);
136140

0 commit comments

Comments
 (0)