Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Release and tag is not created when merging the release PR using the Github CLI #1067

Open
nils1k opened this issue Dec 18, 2024 · 4 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nils1k
Copy link

nils1k commented Dec 18, 2024

Describe the error

Neither a tag, nor a release, is being created when merging the release PR using the Github CLI.

Steps to reproduce

  1. Push a commit so that a release PR is generated
  2. Merge the PR manually so that a release and tag are created
  3. Push a commit so that a new release PR is generated
  4. Use the Github CLI to merge the release PR, e.g. gh pr merge <pr_number> --squash
  5. The release PR is merged, but neither a release, nor a tag, is a created

Please refer to the sample code that reproduces the issue.

@nils1k nils1k added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 18, 2024
@nzakas
Copy link

nzakas commented Jan 25, 2025

I've also been fighting with this for the past week. It seems like the release four months ago broke a lot of the functionality as I've had several projects now broken in the same way. As a result, my release processes are all broken.

@nzakas
Copy link

nzakas commented Jan 25, 2025

Additionally, now one project just keeps creating PRs every time I merge one:

humanwhocodes/mentoss#17
humanwhocodes/mentoss#16
humanwhocodes/mentoss#15

@dy0gu
Copy link

dy0gu commented Jan 27, 2025

Additionally, now one project just keeps creating PRs every time I merge one:

humanwhocodes/mentoss#17 humanwhocodes/mentoss#16 humanwhocodes/mentoss#15

The infinite PR bug is a new thing and it's GitHub that broke, release-please can't create the labels for the PR because GitHub seems to have broken token permissions on label creation.

It's happening to all new repositories that use release-please, not just you.

See here: https://github.com/orgs/community/discussions/149877#discussioncomment-11952379

And here for specific release-please workarounds by manually creating the labels: #1074

@nzakas
Copy link

nzakas commented Jan 29, 2025

Thanks. To make it easier for anyone else finding this issue: the solution is to manually create the labels in your issues list:

  • autorelease: pending
  • autorelease: tagged
  • autorelease: snapshot
  • autorelease: published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants