Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions[bot] doesn't update description of release pr when main branch have a new update #1075

Open
kitimark opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kitimark
Copy link

kitimark commented Jan 17, 2025

github-actions[bot] doesn't update description of release pr when main branch have a new update, but changelog file is fine

issue ref: kitimark/timeloc#4

Expected description of pr

## 🤖 I have created a release beep boop

## 1.0.0 (2025-01-17)

### Features

* initiate timeloc ([9f74683](https://github.com/kitimark/timeloc/commit/9f74683fc15fea4140cd796304355a4e28840b4d))
* **timeloc:** not allowed time.Local usage ([#1](https://github.com/kitimark/timeloc/issues/1)) ([9dc1b44](https://github.com/kitimark/timeloc/commit/9dc1b447f617def2329a58e2faefec965133ed35))

### Bug Fixes

* **timeloc:** detect false positive when time package is aliased ([#5](https://github.com/kitimark/timeloc/issues/5)) ([ad2e216](https://github.com/kitimark/timeloc/commit/ad2e2168388186d660cdd32592297376dc0ad3f0))
* **timeloc:** program will panic, when function have a built-in interface in argument ([be6b6c3](https://github.com/kitimark/timeloc/commit/be6b6c314ae399d9d833b75db91835d7eca4c793))

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Actual description of pr

a fixed commit is lost

## 🤖 I have created a release beep boop

## 1.0.0 (2025-01-17)

### Features

* initiate timeloc ([9f74683](https://github.com/kitimark/timeloc/commit/9f74683fc15fea4140cd796304355a4e28840b4d))
* **timeloc:** not allowed time.Local usage ([#1](https://github.com/kitimark/timeloc/issues/1)) ([9dc1b44](https://github.com/kitimark/timeloc/commit/9dc1b447f617def2329a58e2faefec965133ed35))

### Bug Fixes

* **timeloc:** detect false positive when time package is aliased ([#5](https://github.com/kitimark/timeloc/issues/5)) ([ad2e216](https://github.com/kitimark/timeloc/commit/ad2e2168388186d660cdd32592297376dc0ad3f0))

This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Screenshot
Image

Steps to reproduce

  1. create some change and merge to main
  2. github-actions[bot] will create release pr
  3. create more change and merge to main (in this case, fix a bug)
  4. github-actions[bot] will force-push commit in the same pr but it doesn't update description

Environment details

  • Programming language: Golang
  • OS: Ubuntu
  • language runtime version: 1.22
  • release-please version: 16.12.0
  • github action version: googleapis/release-please-action@v4

Thanks guys!

@kitimark kitimark added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 17, 2025
@kitimark
Copy link
Author

kitimark commented Jan 17, 2025

I try to re-run with debug mode. from this job, i found a commit is lost during update pull request.

It seems like the problem is happened during try to create new description before update pull request.

##[debug]Set output prs_created = true
##[debug]Set output pr = {"headBranchName":"release-please--branches--main","baseBranchName":"main","number":4,"title":"chore(main): release 1.0.0","body":":robot: I have created a release *beep* *boop*\n
---\n\n\n
## 1.0.0 (2025-01-17)\n\n\n
### Features\n\n
* initiate timeloc ([9f74683](https://github.com/kitimark/timeloc/commit/9f74683fc15fea4140cd796304355a4e28840b4d))\n
* **timeloc:** not allowed time.Local usage ([#1](https://github.com/kitimark/timeloc/issues/1)) ([9dc1b44](https://github.com/kitimark/timeloc/commit/9dc1b447f617def2329a58e2faefec965133ed35))\n\n\n
### Bug Fixes\n\n
* **timeloc:** program will panic, when function have a built-in interface in argument ([be6b6c3](https://github.com/kitimark/timeloc/commit/be6b6c314ae399d9d833b75db91835d7eca4c793))\n\n
---\n
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).","files":[],"labels":[]}
##[debug]Set output prs = [{"headBranchName":"release-please--branches--main","baseBranchName":"main","number":4,"title":"chore(main): release 1.0.0","body":":robot: I have created a release *beep* *boop*\n
---\n\n\n
## 1.0.0 (2025-01-17)\n\n\n
### Features\n\n
* initiate timeloc ([9f74683](https://github.com/kitimark/timeloc/commit/9f74683fc15fea4140cd796304355a4e28840b4d))\n
* **timeloc:** not allowed time.Local usage ([#1](https://github.com/kitimark/timeloc/issues/1)) ([9dc1b44](https://github.com/kitimark/timeloc/commit/9dc1b447f617def2329a58e2faefec965133ed35))\n\n\n
### Bug Fixes\n\n
* **timeloc:** program will panic, when function have a built-in interface in argument ([be6b6c3](https://github.com/kitimark/timeloc/commit/be6b6c314ae399d9d833b75db91835d7eca4c793))\n\n
---\n
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).","files":[],"labels":[]}]

@kitimark
Copy link
Author

I'm trying to run release-please on my computer via v16.12.0. It still got a bugs like this issues.

But trying to it on my computer via v16.15.0. it works fined.

I'm not sure why my github action workflow still use release-please via v16.12.0 (it's outdated).

I hope my investigation will help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants