Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request links in changelog use "issue" instead of "pull" in the URLs #1079

Open
WillGibson opened this issue Feb 19, 2025 · 0 comments
Open
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@WillGibson
Copy link

WillGibson commented Feb 19, 2025

If the support paths suggested above still do not result in a resolution, please provide the following details.

Environment details

  • Programming language: Python, though I'm not sure that has any bearing.
  • OS: Ubuntu 24.04.1
  • Language runtime version: 3.12.4, though I'm not sure that has any bearing.
  • Package version: 16.12.0

Steps to reproduce

Use release please-action with the following configuration...

.github/workflows/create-release.yml

jobs:
  create-release:
    runs-on: ubuntu-latest
    steps:
      - uses: googleapis/release-please-action@v4
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          config-file: release-config.json
          manifest-file: release-manifest.json

release-config.json

{
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
  "packages": {
    ".": {
        "release-type": "python",
        "include-v-in-tag": false,
        "draft": false,
        "pull-request-header": ":robot: Next release",
        "pull-request-footer": " "
    }
  }
}

CHANGELOG.md includes links like this...

[#764](https://github.com/uktrade/platform-tools/issues/764)

...when we would expect...

[#764](https://github.com/uktrade/platform-tools/pull/764)
@WillGibson WillGibson added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants