Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can a file be updated in a mono repo scenario that is outside of the package path? #2477

Open
seansilvestri opened this issue Feb 12, 2025 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@seansilvestri
Copy link

Thanks for stopping by to ask us a question! Please make sure to include:

  • What you're trying to do
  • What code you've already tried
  • Any error messages you're getting

Hi there,
I'm looking to update a file that is outside of the package path in a monorepo scenario, want to set the branch on a gitaction with the version.
However, not matter what I try I get an error because it can't find the file and I assume it needs to be within the package path.

Error: release-please failed: illegal pathing characters in path: actions/check-auto-sync/../../.github/workflows/check-auto-sync.yaml

Are there any recommended workarounds?

"actions/check-auto-sync": {
      "release-type": "simple",
      "changelog-path": "CHANGELOG.md",
      "extra-files": [
        {
          "type": "yaml",
          "path": "../../.github/workflows/check-auto-sync.yaml",
          "jsonpath": "$.jobs.check-argo-cd-auto-sync.steps[?(@.name=='Check ArgoCD Auto Sync Is Disabled')].uses",
          "value": "sentinel-one/cd-automation/actions/check-auto-sync@${version}"
        }
      ]
    }
@seansilvestri seansilvestri added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Feb 12, 2025
@seansilvestri seansilvestri changed the title How can a file be updated in a mono repo scenario that is outsife of the package path? How can a file be updated in a mono repo scenario that is outside of the package path? Feb 12, 2025
@daviddenton
Copy link

We have a similar but potentially different scenario. We are trying to release several packages from a single monorepo, but with each package having shared source dependencies which are outside of their own tree.

For example, we have a repo with:

/app/diary
/lib/date_picker

In the above, diary is dependent on date_picker. We'd like changes inside date_picker to also trigger an entry in the diary changelog.

We have tried using the root as '/' and then mapping diary to /app/diary in the config, then using extra-files with a glob entry of ...

{
   "type": "generic"
  "path": "/lib/date_picker/**"
   "glob": true
   "
}

.. but this does not seem to trigger an entry to be created when we do a commit to /lib/date_picker/package.json.

We're not sure if RP currently is designed to handle our use-case or even if it's possible by extension (maybe a custom strategy?). 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants