Skip to content

Commit e3f7e25

Browse files
fix(utils): resolve type errors (#587)
Resolves TypeScript errors in the 'utils' directory by: - Adding a placeholder function for `myFunction`. - Removing an unhelpful try/catch block. - Adding a JSDoc type annotation for a variable. - Correcting a call to `SpreadsheetApp.openById`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 parent 875f561 commit e3f7e25

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

utils/logging.gs

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@
1515
*/
1616

1717
// [START apps_script_logging_execution_time]
18+
/**
19+
* A placeholder function to be timed.
20+
* @param {Object} parameters
21+
*/
22+
function myFunction(parameters) {
23+
// Placeholder for the function being timed.
24+
}
25+
1826
/**
1927
* Logs the time taken to execute 'myFunction'.
2028
*/
@@ -51,15 +59,10 @@ function measuringExecutionTime() {
5159
*/
5260
function emailDataRow(rowNumber, email) {
5361
console.log('Emailing data row ' + rowNumber + ' to ' + email);
54-
try {
55-
const sheet = SpreadsheetApp.getActiveSheet();
56-
const data = sheet.getDataRange().getValues();
57-
const rowData = data[rowNumber - 1].join(' ');
58-
console.log('Row ' + rowNumber + ' data: ' + rowData);
59-
MailApp.sendEmail(email, 'Data in row ' + rowNumber, rowData);
60-
} catch (err) {
61-
// TODO (developer) - Handle exception
62-
console.log('Failed with error %s', err.message);
63-
}
62+
const sheet = SpreadsheetApp.getActiveSheet();
63+
const data = sheet.getDataRange().getValues();
64+
const rowData = data[rowNumber - 1].join(' ');
65+
console.log('Row ' + rowNumber + ' data: ' + rowData);
66+
MailApp.sendEmail(email, 'Data in row ' + rowNumber, rowData);
6467
}
6568
// [END apps_script_logging_sheet_information]

utils/test_logging.gs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ function populateValues(spreadsheetId) {
3434
const batchUpdateRequest = Sheets.newBatchUpdateSpreadsheetRequest();
3535
const repeatCellRequest = Sheets.newRepeatCellRequest();
3636

37+
/** @type {string[][]} */
3738
const values = [];
3839
for (let i = 0; i < 10; ++i) {
3940
values[i] = [];
@@ -54,7 +55,7 @@ function itShouldEmailDataRow() {
5455
const email = Session.getActiveUser().getEmail();
5556
const spreadsheetId = createTestSpreadsheet();
5657
populateValues(spreadsheetId);
57-
const data = Spreadsheet.openById();
58+
const data = SpreadsheetApp.openById(spreadsheetId);
5859
emailDataRow(1, email);
5960
}
6061

0 commit comments

Comments
 (0)