Skip to content

Commit 2e04f5a

Browse files
authored
Add upgrade note for v.58
1 parent 17f6ef8 commit 2e04f5a

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

README.md

+11
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,17 @@ services:
4040

4141
[Here is an equivalent docker run script](https://github.com/pi-hole/docker-pi-hole/blob/master/docker_run.sh).
4242

43+
## Upgrade Notes
44+
45+
### v5.8+
46+
A check has been added in v5.8 to ensure that the `PIHOLE_DNS_` value is correct, a common error is that quotes are passed through to the script, usually because the environment variable has been defined as, e.g. `- PIHOLE_DNS_='10.0.0.2#5053;1.1.1.1'`. The following declarations are valid:
47+
- `PIHOLE_DNS_: 10.0.0.2#5053;1.1.1.1`
48+
- `PIHOLE_DNS_: '10.0.0.2#5053;1.1.1.1'`
49+
- `- PIHOLE_DNS_=10.0.0.2#5053;1.1.1.1`
50+
51+
52+
See [Docker documentation](https://docs.docker.com/compose/compose-file/compose-file-v3/#environment) for more detail, and discussion in [this issue thread](https://github.com/pi-hole/docker-pi-hole/issues/838)
53+
4354
## Overview
4455

4556
#### Renamed from `diginc/pi-hole` to `pihole/pihole`

0 commit comments

Comments
 (0)