Strict Slashes don't work

[swizzley]

What version of Go are you running? (Paste the output of go version)
go version go1.12.5 darwin/amd64

What version of gorilla/mux are you at? (Paste the output of git rev-parse HEAD inside $GOPATH/src/github.com/gorilla/mux)
github.com/gorilla/mux v1.7.2

Describe your problem (and what you have tried so far)
rtr = mux.NewRouter().StrictSlash(true)
rtr.HandleFunc("/health/", health)

opening /health will always result in 404 instead of 301

Paste a minimal, runnable, reproduction of your issue below (use backticks to format it)

package main

import (
	"github.com/gorilla/mux"
	"net/http"
	"encoding/json"
)

func main() {
	rtr := mux.NewRouter().StrictSlash(true)
	rtr.HandleFunc("/health/", health)
	s := &http.Server{
		Addr:           ":8080",
		Handler:        rtr,
	}
	s.ListenAndServe()

}

func health(w http.ResponseWriter, r *http.Request) {
	status := struct {
		Status string
	}{
		"OK",
	}
	w.Header().Set("Content-Type", "application/json")
	j, _ := json.Marshal(status)
	w.Write(j)
}

[elithrar]

Please upgrade to the latest version of mux - I'm not able to replicate this on the latest version. (5bbbb is from early 2018). ➜ curl -svL localhost:8080/health/ 2>&1 | rg '< HTTP' < HTTP/1.1 200 OK ➜ curl -svL localhost:8080/health 2>&1 | rg '< HTTP' < HTTP/1.1 301 Moved Permanently < HTTP/1.1 200 OK

…

On Fri, May 3, 2019 at 9:20 AM Dustin Morgan ***@***.***> wrote: *What version of Go are you running?* (Paste the output of go version) github.com/gorilla/mux v0.0.0-20180107155708-5bbbb5b2b572 *What version of gorilla/mux are you at?* (Paste the output of git rev-parse HEAD inside $GOPATH/src/github.com/gorilla/mux) github.com/gorilla/mux v0.0.0-20180107155708-5bbbb5b2b572 *Describe your problem* (and what you have tried so far) rtr = mux.NewRouter().StrictSlash(true) rtr.HandleFunc("/health/", health) opening /health will always result in 404 instead of 301 *Paste a minimal, runnable, reproduction of your issue below* (use backticks to format it) package main import ( "github.com/gorilla/mux" "net/http" "encoding/json" ) func main() { rtr := mux.NewRouter().StrictSlash(true) rtr.HandleFunc("/health/", health) s := &http.Server{ Addr: ":8080", Handler: rtr, } s.ListenAndServe() } func health(w http.ResponseWriter, r *http.Request) { status := struct { Status string }{ "OK", } w.Header().Set("Content-Type", "application/json") j, _ := json.Marshal(status) w.Write(j) } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#472>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAEQ4BODA74DC5DP57UTSLPTRQ3ZANCNFSM4HKVH3FQ> .

[mattheusv]

I'm usually configure my handle func more like this:

rtr.HandleFunc("/health", health)

and, when I call /health and /health/ I get status code 200 to both

[houspiller]

I have the same problem....

router := mux.NewRouter().StrictSlash(true)
	s := router.PathPrefix("/v0").Subrouter().StrictSlash(true)

	s.HandleFunc("/health/", HealthCheckHandler).Methods("GET")
	s.HandleFunc("/tags/", CreateTagHandler).Methods("POST")
	s.HandleFunc("/tags/", GetTagsHandler).Methods("GET")

1. The StrictSlash in subrouter dont work
2. When I post in tags without the final '/', the return is the GET. Its bizarre...

[elithrar]

Can you show how you're testing this?

…

On Mon, May 20, 2019 at 8:06 AM Fernando Campos Schelb < ***@***.***> wrote: I have the same problem.... router := mux.NewRouter().StrictSlash(true) s := router.PathPrefix("/v0").Subrouter().StrictSlash(true) s.HandleFunc("/health/", HealthCheckHandler).Methods("GET") s.HandleFunc("/tags/", CreateTagHandler).Methods("POST") s.HandleFunc("/tags/", GetTagsHandler).Methods("GET") 1. The StrictSlash in subrouter dont work 2. When I post in tags without the final '/', the return is the GET. Its bizarre... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#472?email_source=notifications&email_token=AAAEQ4DI3EH77CYGPMFUT6DPWK45XA5CNFSM4HKVH3F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVZEAOQ#issuecomment-494026810>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAEQ4BVCUDYLGQPSUVNF43PWK45XANCNFSM4HKVH3FQ> .

[houspiller]

I made a post in Postman...

[POST] http://localhost:6000/v0/tags

and the body in response is the same body for the GET

[the-jackalope]

From the docs

The re-direct is a HTTP 301 (Moved Permanently). Note that when this is set for routes with a non-idempotent method (e.g. POST, PUT), the subsequent re-directed request will be made as a GET by most clients. Use middleware or client settings to modify this behaviour as needed.

This may explain why some of you are hitting the GET handler instead of the POST when using strict slash.

[swizzley]

So I updated to the latest version of Mux and the issue persists

{
			"ImportPath": "github.com/gorilla/mux",
			"Comment": "v1.7.2",
			"Rev": "ed099d42384823742bba0bf9a72b53b55c9e2e38"
},

[elithrar]

It's not a _bug_ - this is the HTTP spec. Returning a 301/302 to a POST/PUT/DELETE (any non-idempotent method) will cause the client to retry as a GET, for safety. Middleware can modify this to return a 307/308 instead, if need be.

…

On Wed, Jun 19, 2019 at 11:57 AM Dustin Morgan ***@***.***> wrote: So I updated to the latest version of Mux and the issue persists — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#472?email_source=notifications&email_token=AAAEQ4DHQOHCVG6WHOZCOXDP3J6R3A5CNFSM4HKVH3F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYC2NLI#issuecomment-503686829>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAEQ4AOP4BJQB35UJ3R4V3P3J6R3ANCNFSM4HKVH3FQ> .

[elithrar]

See my comments - #451 (comment) and this full example of middleware.