-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Run code blocks" workflow to work with unreleased k6 features #1910
Comments
@federicotdn I opened an issue for this so we can chat about possible solutions here instead of Slack. 🤓 I was wondering if one possible solution would be to add a way to skip the workflow for a PR that doesn't involve adding any line of code to files? Like something in the PR description or title. |
@heitortsergent if we skip code blocks via PR description, how can we ensure that the code block will be run later on? Someone would need to coincidentally modify the same file at some later point - and by that time (simultaneously) the latest version of k6 must also have whatever feature the originally-skipped code block uses. I think it would work sometimes but the overall system would be a bit brittle. IMO it's better just to |
Other possible solutions:
|
I think relying on folks opening an issue and going back to remove And, maybe this is a separate issue, but the other part of this is when someone has a PR that touches on a lot of files, adding/removing a bunch of |
Ok, I took a crack at it: #1917 - there, we build k6 from
Yeah in those cases I think there's no other option than to read the PR content or something similar. |
The
run-code-blocks
workflow helps us make sure that any code snippets are valid and work with the latest version of k6.One of the problems we've run into is when opening PRs that are related to a feature that's still unreleased, and will only be available in the next version of k6.
We could use the
skip
option to skip any code blocks for unreleased features, and then remove those later after the new version of k6 is released, but I think this would likely lead to errors. It's also harder to do if it's a change that affects many files.We should try to think of some alternatives for how to best handle this, in a way that's easy for maintainers, and allows us to continue to use the workflow.
The text was updated successfully, but these errors were encountered: