-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to disable cpu profiling endpoint in promtail #5005
Comments
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
Add a `server.profiling_enabled` option (that defaults to `false`) to enable the `/debug/fgprof` endpoint in Promtail. Fixes grafana#5005
**What this PR does / why we need it**: Add a `server.debug` option (that defaults to `false`) to enable the `/debug/fgprof` endpoint in Promtail. **Which issue(s) this PR fixes**: Fixes #5005 Co-authored-by: Trevor Whitney <[email protected]>
**What this PR does / why we need it**: Add a `server.debug` option (that defaults to `false`) to enable the `/debug/fgprof` endpoint in Promtail. **Which issue(s) this PR fixes**: Fixes grafana#5005 Co-authored-by: Trevor Whitney <[email protected]>
There is an undocumented(?) API endpoint in Promtail for CPU profiling:
/debug/fgprof
:loki/clients/pkg/promtail/server/server.go
Line 106 in bd1fef0
Considering felixge/fgprof#12 one might want to disable this endpoint.
There should be a configuration option to disable it (or enable it if needed). There should also be documentation about this feature.
Yes, it can be done in an upstream reverse proxy, but having a configuration option would be better IMHO.
The text was updated successfully, but these errors were encountered: