Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable cpu profiling endpoint in promtail #5005

Closed
Fluepke opened this issue Dec 27, 2021 · 1 comment · Fixed by #5400
Closed

Add configuration option to disable cpu profiling endpoint in promtail #5005

Fluepke opened this issue Dec 27, 2021 · 1 comment · Fixed by #5400
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@Fluepke
Copy link

Fluepke commented Dec 27, 2021

There is an undocumented(?) API endpoint in Promtail for CPU profiling: /debug/fgprof:

serv.HTTP.Path("/debug/fgprof").Handler(fgprof.Handler())

Considering felixge/fgprof#12 one might want to disable this endpoint.
There should be a configuration option to disable it (or enable it if needed). There should also be documentation about this feature.

Yes, it can be done in an upstream reverse proxy, but having a configuration option would be better IMHO.

@stale
Copy link

stale bot commented Mar 2, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 2, 2022
@stale stale bot closed this as completed Apr 18, 2022
BenoitKnecht added a commit to BenoitKnecht/loki that referenced this issue Oct 25, 2022
Add a `server.profiling_enabled` option (that defaults to `false`) to enable
the `/debug/fgprof` endpoint in Promtail.

Fixes grafana#5005
trevorwhitney added a commit that referenced this issue Nov 8, 2022
**What this PR does / why we need it**:

Add a `server.debug` option (that defaults to `false`) to enable the
`/debug/fgprof` endpoint in Promtail.

**Which issue(s) this PR fixes**:
Fixes #5005

Co-authored-by: Trevor Whitney <[email protected]>
Abuelodelanada pushed a commit to canonical/loki that referenced this issue Dec 1, 2022
**What this PR does / why we need it**:

Add a `server.debug` option (that defaults to `false`) to enable the
`/debug/fgprof` endpoint in Promtail.

**Which issue(s) this PR fixes**:
Fixes grafana#5005

Co-authored-by: Trevor Whitney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant