Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Gateway startup issues #16

Open
klvnnsrikanth opened this issue Mar 14, 2023 · 5 comments
Open

Gateway startup issues #16

klvnnsrikanth opened this issue Mar 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@klvnnsrikanth
Copy link

klvnnsrikanth commented Mar 14, 2023

Describe the bug
Seems like the logback locations provided does not work for everyone.
Probably need to make them generic or use the location of the project directory.

Have you tried starting it up recently?
Not meant to call out, but seeing an issue with RuntimeGraphBuilder build method line 59.
local registry setup does not work, what if I don't have a AWS account? May be provide alternatives.
Probably add documentation on why AWS account if required. What does it do when it runs setup.sh and start.sh in local registry. I think any kind of more documentation can help.

To Reproduce

Startup the application without aws configure.

Expected behavior

Gateway boots up properly.

Additional context
Compilation issues with just mvn clean build

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project graphql-gateway-java: Compilation failure
[ERROR] ...../graph-quilt-gateway/src/main/java/com/intuit/graphql/gateway/graphql/RuntimeGraphBuilder.java:[59,48] incompatible types: invalid method reference
[ERROR] incompatible types: java.lang.Object cannot be converted to com.intuit.graphql.orchestrator.ServiceProvider
[ERROR]

logback xml locations

It will fail to create these folders since not everyone would have root access, so probably change to PROJECT_DIR

@klvnnsrikanth klvnnsrikanth added the bug Something isn't working label Mar 14, 2023
@klvnnsrikanth
Copy link
Author

Seems like an issue with my setup for local_registry, after having the docker daemon running I was able to setup the local_registry.

@klvnnsrikanth
Copy link
Author

Still getting the compilation error as mentioned in the Additional Context.

@klvnnsrikanth
Copy link
Author

Also please migrate the JAVA version to 17, since its the LTS version.

@ashpak-shaikh
Copy link
Contributor

@klvnnsrikanth Thanks for pointing it out. We will be looking into this issue.
We recently open sourced this and still have a lot of items on our OSS roadmap.
Would you be open to setup a short call so that we can understand your requirements so we can prioritize on our end. We can also share some of the undocumented features that may help you understand the whole graph-quilt ecosystem better.

@CNAChino CNAChino self-assigned this Apr 26, 2023
@CNAChino
Copy link
Contributor

@klvnnsrikanth Thanks for raising this issue.
For logback, it is now logging on logs directory which is located in project's folder. Log folder content will be ignored by git.

The invalid method reference seems an Issue with Java 17. Still need to look at Java 17 as I see more build error. Java 11 migration is already in the works.

Localstack is used to mock AWS S3 if this app is run locally and real AWS Account is not needed. When you run aws configure, just put any value when prompted. That should work with localstack.

Lastly, did some minor update on README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants