-
Notifications
You must be signed in to change notification settings - Fork 1.7k
remove deprecated ISO8601DateFormat #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
..which shows I am missing client tests for the Good thing is, Janek's client doesn't care and correctly parses whatever it gets, so I'll just put in |
But could this break other clients? If yes, we should either postpone or explicitely document it somewhere.
Would you mind to add a test so that we can be "less carefull" :) ? |
In theory yes, but only if the client was expecting more than what we promised, i.e. not only producing ISO-8601, but a very specific way of writing ISO-8601. I think at this point we can still say that would be the client's problem. (Actually, the previous way was somewhat more exotic than the current way, so I'd say it's unlikely.)
Er yes, sure. |
Ok.
Thanks :) ! |
(Actually, the previous way was somewhat more exotic than the current way, so I'd say it's unlikely.) |
It looks we can remove the call
bootstrap.getObjectMapper().setDateFormat(new ISO8601DateFormat());
as this is recommended according the linked issue and all tests are still green.
The text was updated successfully, but these errors were encountered: