Skip to content

Commit 372310a

Browse files
perrin4869nodkz
authored andcommitted
fix: PageInfo must define one or more fields
Fixes a regression introduced in `v3.1`. `schemaComposer.createObjectTC` accepts a `typeDef`, which could be a `string` (as in https://github.com/graphql-compose/graphql-compose-elasticsearch/blob/v3.1.1/src/resolvers/searchConnection.js#L141). `cfg` does not have `field` attributes in this case, causing `PageInfo` to be empty. Closes #60
1 parent 99e53e2 commit 372310a

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

src/utils.js

+9-12
Original file line numberDiff line numberDiff line change
@@ -38,28 +38,25 @@ export function prepareCommonOpts<TContext>(
3838
schemaComposer,
3939
getOrCreateOTC: (typeName, cfgOrThunk) => {
4040
return schemaComposer.getOrSet(typeName, () => {
41-
const tc = schemaComposer.createObjectTC(typeName);
42-
const cfg = isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk;
43-
tc.setFields(cfg.fields);
44-
tc.setDescription(cfg.description);
41+
const tc = schemaComposer.createObjectTC(
42+
isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk
43+
);
4544
return tc;
4645
});
4746
},
4847
getOrCreateITC: (typeName, cfgOrThunk) => {
4948
return schemaComposer.getOrSet(typeName, () => {
50-
const tc = schemaComposer.createInputTC(typeName);
51-
const cfg = isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk;
52-
tc.setFields(cfg.fields);
53-
tc.setDescription(cfg.description);
49+
const tc = schemaComposer.createInputTC(
50+
isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk
51+
);
5452
return tc;
5553
});
5654
},
5755
getOrCreateETC: (typeName, cfgOrThunk) => {
5856
return schemaComposer.getOrSet(typeName, () => {
59-
const tc = schemaComposer.createEnumTC(typeName);
60-
const cfg = isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk;
61-
tc.setFields(cfg.values);
62-
tc.setDescription(cfg.description);
57+
const tc = schemaComposer.createEnumTC(
58+
isFunction(cfgOrThunk) ? (cfgOrThunk: any)() : cfgOrThunk
59+
);
6360
return tc;
6461
});
6562
},

0 commit comments

Comments
 (0)