Skip to content

Commit 0ef678f

Browse files
committed
fix: build errors after library updates
1 parent fdc6e9e commit 0ef678f

File tree

18 files changed

+47
-52
lines changed

18 files changed

+47
-52
lines changed

.github/workflows/master.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ jobs:
2323
uses: actions/setup-java@v3
2424
with:
2525
distribution: 'temurin'
26-
java-version: 11
26+
java-version: 17
2727
- name: Cache Gradle
2828
uses: actions/cache@v3
2929
env:
30-
java-version: 11
30+
java-version: 17
3131
with:
3232
path: |
3333
~/.gradle/caches
@@ -48,11 +48,11 @@ jobs:
4848
- uses: actions/checkout@v3
4949
with:
5050
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
51-
- name: Set up JDK 11
51+
- name: Set up JDK 17
5252
uses: actions/setup-java@v3
5353
with:
5454
distribution: 'temurin'
55-
java-version: 11
55+
java-version: 17
5656
- name: Cache SonarCloud packages
5757
uses: actions/cache@v3
5858
with:

.github/workflows/pull-request.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
os: [ ubuntu-latest, macos-latest, windows-latest ]
19-
java: [ 11, 17 ]
19+
java: [ 17, 19 ]
2020
needs: validation
2121
runs-on: ${{ matrix.os }}
2222
steps:

build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ plugins {
44
id "jacoco"
55
}
66

7-
sonarqube {
7+
sonar {
88
properties {
99
property "sonar.projectKey", "graphql-java-kickstart_graphql-java-kickstart-samples"
1010
property "sonar.organization", "graphql-java-kickstart"
@@ -27,8 +27,8 @@ subprojects {
2727
}
2828

2929
compileJava {
30-
sourceCompatibility = JavaVersion.VERSION_11
31-
targetCompatibility = JavaVersion.VERSION_11
30+
sourceCompatibility = JavaVersion.VERSION_17
31+
targetCompatibility = JavaVersion.VERSION_17
3232
}
3333

3434
test {
@@ -37,7 +37,7 @@ subprojects {
3737

3838
jacocoTestReport {
3939
reports {
40-
xml.enabled = true
40+
xml.required = true
4141
}
4242
}
4343
}
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
package graphql.kickstart.sample;
22

3+
import org.springframework.context.annotation.Bean;
34
import org.springframework.context.annotation.Configuration;
45
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
56
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
6-
import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
7+
import org.springframework.security.web.SecurityFilterChain;
78

89
@Configuration
910
@EnableWebSecurity
10-
class SecurityConfig extends WebSecurityConfigurerAdapter {
11+
class SecurityConfig {
1112

12-
@Override
13-
protected void configure(final HttpSecurity http) throws Exception {
14-
http.authorizeRequests().anyRequest().permitAll();
13+
@Bean
14+
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
15+
http.authorizeHttpRequests().anyRequest().permitAll();
16+
return http.build();
1517
}
1618
}

file-upload/src/main/java/upload/UploadMutation.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import graphql.kickstart.tools.GraphQLMutationResolver;
44
import java.io.IOException;
5-
import javax.servlet.http.Part;
5+
import jakarta.servlet.http.Part;
66
import lombok.extern.slf4j.Slf4j;
77
import org.springframework.stereotype.Service;
88

gradle.properties

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
LIB_GRAPHQL_SERVLET_VER=14.0.0
1+
LIB_GRAPHQL_SERVLET_VER=15.0.0
22
LIB_GRAPHQL_SPRING_BOOT_VER=15.0.0
33
LIB_GRAPHQL_TOOLS_VER=13.0.2
44
LIB_GRAPHQL_EXTENDED_VALIDATION_VER=19.1
5-
LIB_SPRING_BOOT_VER=2.7.6
6-
sourceCompatibility=11
7-
targetCompatibility=11
5+
LIB_SPRING_BOOT_VER=3.0.0

graphql-annotations/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ dependencies {
55

66
implementation("org.springframework.boot:spring-boot-starter-web")
77
implementation("org.springframework.boot:spring-boot-starter-data-jpa")
8-
implementation "io.reactivex.rxjava2:rxjava"
8+
implementation "io.reactivex.rxjava2:rxjava:2.2.21"
99
implementation "org.projectlombok:lombok"
1010
annotationProcessor "org.projectlombok:lombok"
1111
runtimeOnly("com.h2database:h2")

graphql-annotations/src/main/java/graphql/kickstart/spring/boot/graphql/annotations/example/model/type/Person.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
import graphql.annotations.annotationTypes.GraphQLNonNull;
66
import graphql.kickstart.spring.boot.graphql.annotations.example.model.directives.UpperCaseDirective;
77
import java.time.LocalDate;
8-
import javax.persistence.Column;
9-
import javax.persistence.Entity;
10-
import javax.persistence.Id;
8+
import jakarta.persistence.Column;
9+
import jakarta.persistence.Entity;
10+
import jakarta.persistence.Id;
1111
import lombok.AllArgsConstructor;
1212
import lombok.Builder;
1313
import lombok.Data;

graphql-annotations/src/test/java/graphql/kickstart/spring/boot/graphql/annotations/example/CreatePersonTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
2424
@Slf4j
25-
public class CreatePersonTest {
25+
class CreatePersonTest {
2626

2727
private static final String FIRST_NAME = "John";
2828
private static final String LAST_NAME = "Doe";

request-scoped-dataloader/src/main/java/graphql/servlet/examples/dataloader/requestscope/CustomGraphQLContextBuilder.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
import graphql.kickstart.servlet.context.GraphQLServletContextBuilder;
77
import java.util.HashMap;
88
import java.util.Map;
9-
import javax.servlet.http.HttpServletRequest;
10-
import javax.servlet.http.HttpServletResponse;
11-
import javax.websocket.Session;
12-
import javax.websocket.server.HandshakeRequest;
9+
import jakarta.servlet.http.HttpServletRequest;
10+
import jakarta.servlet.http.HttpServletResponse;
11+
import jakarta.websocket.Session;
12+
import jakarta.websocket.server.HandshakeRequest;
1313
import org.dataloader.DataLoader;
1414
import org.dataloader.DataLoaderFactory;
1515
import org.dataloader.DataLoaderRegistry;

servlet-hello-world/build.gradle

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
def jettyVersion = '9.4.49.v20220914'
1+
def jettyVersion = '11.0.12'
22

33
dependencies {
44
implementation "com.graphql-java-kickstart:graphql-java-servlet:$LIB_GRAPHQL_SERVLET_VER"
@@ -7,8 +7,5 @@ dependencies {
77
implementation 'org.slf4j:slf4j-simple:2.0.5'
88
implementation "org.eclipse.jetty:jetty-webapp:${jettyVersion}"
99
implementation "org.eclipse.jetty:jetty-annotations:${jettyVersion}"
10-
implementation "org.eclipse.jetty.websocket:websocket-api:${jettyVersion}"
11-
implementation "org.eclipse.jetty.websocket:websocket-server:${jettyVersion}"
12-
implementation "org.eclipse.jetty.websocket:javax-websocket-server-impl:${jettyVersion}"
13-
implementation "org.eclipse.jetty.websocket:websocket-common:${jettyVersion}"
10+
implementation "org.eclipse.jetty.websocket:websocket-jetty-server:${jettyVersion}"
1411
}

servlet-hello-world/src/main/java/hello/GraphQLWSEndpointConfigurer.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package hello;
22

3-
import javax.websocket.HandshakeResponse;
4-
import javax.websocket.server.HandshakeRequest;
5-
import javax.websocket.server.ServerEndpointConfig;
3+
import jakarta.websocket.HandshakeResponse;
4+
import jakarta.websocket.server.HandshakeRequest;
5+
import jakarta.websocket.server.ServerEndpointConfig;
66

77
public class GraphQLWSEndpointConfigurer extends ServerEndpointConfig.Configurator {
88

servlet-hello-world/src/main/java/hello/HttpMain.java

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
package hello;
22

3-
import javax.websocket.server.ServerEndpointConfig;
43
import org.eclipse.jetty.server.Server;
54
import org.eclipse.jetty.server.ServerConnector;
65
import org.eclipse.jetty.servlet.ServletContextHandler;
7-
import org.eclipse.jetty.websocket.jsr356.server.deploy.WebSocketServerContainerInitializer;
6+
import org.eclipse.jetty.websocket.server.config.JettyWebSocketServletContainerInitializer;
87

98
class HttpMain {
109

@@ -21,13 +20,10 @@ public static void main(String[] args) throws Exception {
2120
context.addServlet(HelloServlet.class, "/graphql");
2221
server.setHandler(context);
2322

24-
WebSocketServerContainerInitializer.configure(
23+
JettyWebSocketServletContainerInitializer.configure(
2524
context,
2625
(servletContext, serverContainer) ->
27-
serverContainer.addEndpoint(
28-
ServerEndpointConfig.Builder.create(SubscriptionEndpoint.class, "/subscriptions")
29-
.configurator(new GraphQLWSEndpointConfigurer())
30-
.build()));
26+
serverContainer.addMapping("/subscriptions", GraphQLWSEndpointConfigurer.class));
3127

3228
server.setHandler(context);
3329

spring-boot-commons.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Common settings only needed for Spring Boot based samples
22

33
apply plugin: "io.spring.dependency-management"
4-
apply plugin: "org.springframework.boot"
4+
//apply plugin: "org.springframework.boot"
55

66
dependencyManagement {
77
imports {

spring-common/src/main/java/graphql/kickstart/autoconfigure/web/servlet/sample/schema/TodoSchema.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import java.util.Collection;
3535
import java.util.List;
3636
import java.util.stream.Collectors;
37-
import javax.servlet.http.Part;
37+
import jakarta.servlet.http.Part;
3838

3939
@GraphQLSchema
4040
public class TodoSchema {

subscription-with-authentication/src/main/java/subscription/MySubscriptionResolver.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import graphql.kickstart.tools.GraphQLSubscriptionResolver;
55
import graphql.schema.DataFetchingEnvironment;
66
import java.util.Optional;
7-
import javax.websocket.Session;
7+
import jakarta.websocket.Session;
88
import org.reactivestreams.Publisher;
99
import org.slf4j.Logger;
1010
import org.slf4j.LoggerFactory;
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
package subscription;
22

3+
import org.springframework.context.annotation.Bean;
34
import org.springframework.context.annotation.Configuration;
45
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
5-
import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
6+
import org.springframework.security.web.SecurityFilterChain;
67

78
@Configuration
8-
class SecurityConfiguration extends WebSecurityConfigurerAdapter {
9+
class SecurityConfiguration {
910

10-
@Override
11-
protected void configure(HttpSecurity http) throws Exception {
12-
http.authorizeRequests()
11+
@Bean
12+
public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
13+
http.authorizeHttpRequests()
1314
.anyRequest()
1415
.permitAll()
1516
.and()
@@ -19,5 +20,6 @@ protected void configure(HttpSecurity http) throws Exception {
1920
.and()
2021
.logout()
2122
.permitAll();
23+
return http.build();
2224
}
2325
}

subscription/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ dependencyManagement {
1111
dependencies {
1212
implementation("com.graphql-java-kickstart:graphql-spring-boot-starter")
1313

14-
implementation "io.reactivex.rxjava2:rxjava"
14+
implementation "io.reactivex.rxjava2:rxjava:2.2.21"
1515
implementation "io.projectreactor:reactor-core"
1616
implementation("org.springframework.boot:spring-boot-starter-web")
1717
implementation("org.springframework.boot:spring-boot-starter-websocket")

0 commit comments

Comments
 (0)