Minor changes as suggested by ruff

Author: Cito

pyproject.toml

@@ -165,6 +165,7 @@ ignore = [
   "D401",  # do not always require imperative mood in first line
   "FBT001", "FBT002", "FBT003",  # allow boolean parameters
   "ISC001",  # allow string literal concatenation for auto-formatting
+  "PLC0415",  # allow run-time imports to avoid circular dependencies
   "PGH003",  # type ignores do not need to be specific
   "PLR2004",  # allow some "magic" values
   "PYI034",  # do not check return value of new method

src/graphql/execution/incremental_publisher.py

@@ -64,7 +64,7 @@ class FormattedPendingResult(TypedDict, total=False):
     label: str
 
 
-class PendingResult:
+class PendingResult:  # noqa: PLW1641
     """Pending execution result"""
 
     id: str
@@ -127,7 +127,7 @@ class FormattedCompletedResult(TypedDict, total=False):
     errors: list[GraphQLFormattedError]
 
 
-class CompletedResult:
+class CompletedResult:  # noqa: PLW1641
     """Completed execution result"""
 
     id: str
@@ -192,7 +192,7 @@ class FormattedExecutionResult(TypedDict, total=False):
     extensions: dict[str, Any]
 
 
-class ExecutionResult:
+class ExecutionResult:  # noqa: PLW1641
     """The result of GraphQL execution.
 
     - ``data`` is the result of a successful execution of the query.
@@ -267,7 +267,7 @@ class FormattedInitialIncrementalExecutionResult(TypedDict, total=False):
     extensions: dict[str, Any]
 
 
-class InitialIncrementalExecutionResult:
+class InitialIncrementalExecutionResult:  # noqa: PLW1641
     """Initial incremental execution result."""
 
     data: dict[str, Any] | None
@@ -369,7 +369,7 @@ class FormattedIncrementalDeferResult(TypedDict, total=False):
     extensions: dict[str, Any]
 
 
-class IncrementalDeferResult:
+class IncrementalDeferResult:  # noqa: PLW1641
     """Incremental deferred execution result"""
 
     data: dict[str, Any]
@@ -461,7 +461,7 @@ class FormattedIncrementalStreamResult(TypedDict, total=False):
     extensions: dict[str, Any]
 
 
-class IncrementalStreamResult:
+class IncrementalStreamResult:  # noqa: PLW1641
     """Incremental streamed execution result"""
 
     items: list[Any]
@@ -560,7 +560,7 @@ class FormattedSubsequentIncrementalExecutionResult(TypedDict, total=False):
     extensions: dict[str, Any]
 
 
-class SubsequentIncrementalExecutionResult:
+class SubsequentIncrementalExecutionResult:  # noqa: PLW1641
     """Subsequent incremental execution result."""
 
     __slots__ = "completed", "extensions", "has_next", "incremental", "pending"

src/graphql/language/location.py

@@ -41,6 +41,9 @@ def __eq__(self, other: object) -> bool:
     def __ne__(self, other: object) -> bool:
         return not self == other
 
+    def __hash__(self) -> int:
+        return hash((self.line, self.column))
+
 
 def get_location(source: Source, position: int) -> SourceLocation:
     """Get the line and column for a character position in the source.

src/graphql/language/source.py

@@ -72,6 +72,9 @@ def __eq__(self, other: object) -> bool:
     def __ne__(self, other: object) -> bool:
         return not self == other
 
+    def __hash__(self) -> int:
+        return hash(self.body)
+
 
 def is_source(source: Any) -> TypeGuard[Source]:
     """Test if the given value is a Source object.

src/graphql/pyutils/inspect.py

@@ -171,7 +171,7 @@ def trunc_list(s: list) -> list:
     if len(s) > max_list_size:
         i = max_list_size // 2
         j = i - 1
-        s = s[:i] + [ELLIPSIS] + s[-j:]
+        s = [*s[:i], ELLIPSIS, *s[-j:]]
     return s
 
 

src/graphql/type/definition.py

@@ -479,7 +479,7 @@ class GraphQLFieldKwargs(TypedDict, total=False):
     ast_node: FieldDefinitionNode | None
 
 
-class GraphQLField:
+class GraphQLField:  # noqa: PLW1641
     """Definition of a GraphQL field"""
 
     type: GraphQLOutputType
@@ -644,7 +644,7 @@ class GraphQLArgumentKwargs(TypedDict, total=False):
     ast_node: InputValueDefinitionNode | None
 
 
-class GraphQLArgument:
+class GraphQLArgument:  # noqa: PLW1641
     """Definition of a GraphQL argument"""
 
     type: GraphQLInputType
@@ -1219,7 +1219,7 @@ class GraphQLEnumValueKwargs(TypedDict, total=False):
     ast_node: EnumValueDefinitionNode | None
 
 
-class GraphQLEnumValue:
+class GraphQLEnumValue:  # noqa: PLW1641
     """A GraphQL enum value."""
 
     value: Any
@@ -1394,7 +1394,7 @@ class GraphQLInputFieldKwargs(TypedDict, total=False):
     ast_node: InputValueDefinitionNode | None
 
 
-class GraphQLInputField:
+class GraphQLInputField:  # noqa: PLW1641
     """Definition of a GraphQL input field"""
 
     type: GraphQLInputType

src/graphql/type/directives.py

@@ -49,7 +49,7 @@ class GraphQLDirectiveKwargs(TypedDict, total=False):
     ast_node: ast.DirectiveDefinitionNode | None
 
 
-class GraphQLDirective:
+class GraphQLDirective:  # noqa: PLW1641
     """GraphQL Directive
 
     Directives are used by the GraphQL runtime as a way of modifying execution behavior.

src/graphql/utilities/ast_to_dict.py

@@ -48,7 +48,7 @@ def ast_to_dict(
         res.update(
             {
                 key: ast_to_dict(getattr(node, key), locations, cache)
-                for key in ("kind",) + node.keys[1:]
+                for key in ("kind", *node.keys[1:])
             }
         )
         if locations:

tests/execution/test_defer.py

@@ -214,7 +214,7 @@ def can_compare_pending_result():
         assert result == tuple(args.values())
         assert result == tuple(args.values())[:2]
         assert result != tuple(args.values())[:1]
-        assert result != tuple(args.values())[:1] + (["bar", 2],)
+        assert result != (*tuple(args.values())[:1], ["bar", 2])
         assert result == args
         assert result != {**args, "id": "bar"}
         assert result != {**args, "path": ["bar", 2]}
@@ -239,7 +239,7 @@ def can_compare_completed_result():
         )
         assert result == tuple(args.values())
         assert result != tuple(args.values())[:1]
-        assert result != tuple(args.values())[:1] + ([GraphQLError("oops")],)
+        assert result != (*tuple(args.values())[:1], [GraphQLError("oops")])
         assert result == args
         assert result != {**args, "id": "bar"}
         assert result != {**args, "errors": [{"message": "oops"}]}

tests/language/test_location.py

@@ -41,3 +41,10 @@ def can_compare_with_formatted_location():
         different_location = SourceLocation(2, 2).formatted
         assert not location == different_location  # noqa: SIM201
         assert location != different_location
+
+    def can_be_hashed():
+        location = SourceLocation(1, 2)
+        same_location = SourceLocation(1, 2)
+        assert hash(location) == hash(same_location)
+        different_location = SourceLocation(2, 2)
+        assert hash(location) != hash(different_location)

tests/language/test_source.py

@@ -69,6 +69,13 @@ def can_be_compared():
         assert not source == "bar"  # noqa: SIM201
         assert source != "bar"
 
+    def can_be_hashed():
+        source = Source("foo")
+        same_source = Source("foo")
+        assert hash(source) == hash(same_source)
+        different_source = Source("bar")
+        assert hash(source) != hash(different_source)
+
     def can_create_weak_reference():
         source = Source("foo")
         ref = weakref.ref(source)

tests/pyutils/test_ref_map.py

@@ -28,7 +28,7 @@ def can_create_a_map_with_scalar_keys_and_values():
         assert list(m.items()) == [("a", 1), ("b", 2), ("c", 3)]
         for k, v in m.items():
             assert k in m
-            assert m[k] == v
+            assert m[k] == v  # noqa: PLR1733
             assert m.get(k) == v
             assert v not in m
             with pytest.raises(KeyError):
@@ -65,7 +65,7 @@ def can_create_a_map_with_three_objects_as_keys():
         assert list(m.items()) == [(obj1, 1), (obj2, 2), (obj3, 3)]
         for k, v in m.items():
             assert k in m
-            assert m[k] == v
+            assert m[k] == v  # noqa: PLR1733
             assert m.get(k) == v
             assert v not in m
             with pytest.raises(KeyError):

tests/utilities/test_coerce_input_value.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from math import nan
+from math import isnan, nan
 from typing import Any, NamedTuple
 
 import pytest
@@ -91,7 +91,7 @@ def returns_no_error_for_null_result():
 
         def returns_no_error_for_nan_result():
             result = _coerce_value({"value": nan}, TestScalar)
-            assert expect_value(result) is nan
+            assert isnan(expect_value(result))
 
         def returns_an_error_for_undefined_result():
             result = _coerce_value({"value": Undefined}, TestScalar)
@@ -371,7 +371,7 @@ def returns_nan_as_value():
             result = _coerce_value({}, _get_test_input_object(nan))
             result_value = expect_value(result)
             assert "foo" in result_value
-            assert result_value["foo"] is nan
+            assert isnan(result_value["foo"])
 
     def describe_for_graphql_list():
         TestList = GraphQLList(GraphQLInt)

tests/utilities/test_value_from_ast_untyped.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from math import nan
+from math import isnan, nan
 from typing import Any
 
 from graphql.language import FloatValueNode, IntValueNode, parse_value
@@ -14,8 +14,8 @@ def _compare_value(value: Any, expected: Any):
             assert value is None
         elif expected is Undefined:
             assert value is Undefined
-        elif expected is nan:
-            assert value is nan
+        elif isinstance(expected, float) and isnan(expected):
+            assert isnan(value)
         else:
             assert value == expected
 
@@ -65,7 +65,7 @@ def parses_variables():
         _expect_value_from_vars("$testVariable", None, Undefined)
 
     def parse_invalid_int_as_nan():
-        assert value_from_ast_untyped(IntValueNode(value="invalid")) is nan
+        assert isnan(value_from_ast_untyped(IntValueNode(value="invalid")))
 
     def parse_invalid_float_as_nan():
-        assert value_from_ast_untyped(FloatValueNode(value="invalid")) is nan
+        assert isnan(value_from_ast_untyped(FloatValueNode(value="invalid")))