use enableDevMode() or development condition instead of NODE_ENV

Author: yaacovCR

cspell.yml

@@ -68,8 +68,10 @@ words:
   - deno
   - denoland
   - hashbang
-  - Rspack
   - Rollup
+  - Rspack
+  - Rsbuild
+  - Turbopack
 
   # Website tech
   - Nextra

integrationTests/README.md

@@ -20,7 +20,7 @@ The `conditions` subdirectory contains tests that verify the conditional exports
 
 ### Verifying Development Mode Tests
 
-Each subdirectory represents a different environment/bundler demonstrating enabling development mode by setting the environment variable `NODE_ENV` to `development`.
+Each subdirectory represents a different platform/bundler demonstrating enabling development mode by enabling the `development` condition or by calling `enableDevMode()`.
 
 ### Verifying Production Mode Tests
 

integrationTests/dev-bun/package.json

@@ -2,7 +2,7 @@
   "description": "graphql-js development mode should work with Bun",
   "private": true,
   "scripts": {
-    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun test.js"
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app oven/bun:\"$BUN_VERSION\"-slim bun --conditions=development test.js"
   },
   "dependencies": {
     "graphql": "file:../graphql.tgz"

integrationTests/dev-bun/test.js

@@ -1,4 +1,6 @@
-import { isObjectType } from 'graphql';
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
 
 class GraphQLObjectType {
   get [Symbol.toStringTag]() {

integrationTests/dev-deno-condition-based/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js condition-based development mode should work with Deno",
+  "private": true,
+  "scripts": {
+    "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:latest deno run --conditions=development --allow-env=NODE_ENV test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-deno/test.js renamed to integrationTests/dev-deno-condition-based/test.js

@@ -9,7 +9,7 @@ class GraphQLObjectType {
 try {
   isObjectType(new GraphQLObjectType());
   throw new Error(
-    'Expected isObjectType to throw an error in Deno implicit dev mode.',
+    'Expected isObjectType to throw an error in Deno condition-based development mode.',
   );
 } catch (error) {
   if (!error.message.includes('from another module or realm')) {

integrationTests/dev-deno/package.json renamed to integrationTests/dev-deno-explicit/package.json

@@ -1,5 +1,5 @@
 {
-  "description": "graphql-js development mode should work with Deno",
+  "description": "graphql-js explicit development mode should work with Deno",
   "private": true,
   "scripts": {
     "test": "docker run --rm --volume \"$PWD\":/usr/src/app -w /usr/src/app denoland/deno:alpine-\"$DENO_VERSION\" deno run --allow-env=NODE_ENV test.js"

integrationTests/dev-deno-explicit/test.js

@@ -0,0 +1,20 @@
+import { enableDevMode, isObjectType } from 'graphql';
+
+enableDevMode();
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno explicit development mode.',
+  );
+} catch (error) {
+  if (!error.message.includes('from another module or realm')) {
+    throw error;
+  }
+}

integrationTests/dev-esbuild/package.json

@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm",
+    "build": "esbuild index.js --bundle --outfile=dist/bundle.js --format=esm --conditions=development",
     "test": "npm run build && node dist/bundle.js"
   },
   "dependencies": {

integrationTests/dev-jest/jest.config.js

@@ -0,0 +1,22 @@
+const jestConfig = {
+  testEnvironment: 'node',
+
+  testEnvironmentOptions: {
+    customExportConditions: ['development'],
+  },
+
+  transform: {
+    '^.+\\.(t|j)sx?$': ['@swc/jest'],
+  },
+
+  transformIgnorePatterns: [
+    // Allow 'graphql' to be transformed, ignore all other node_modules.
+    // This regex means: "match /node_modules/ unless it's followed by graphql/"
+    '/node_modules/(?!graphql/)',
+    // Keep Jest's default for .pnp.js files if using Yarn PnP
+    '\\.pnp\\.[^\\/]+$',
+  ],
+};
+
+// eslint-disable-next-line no-restricted-exports, import/no-default-export
+export default jestConfig;