Remove orphaned LoginRateLimitService.java

[davemachado]

What would you like Grimmory to do?

As title says, LoginRateLimitService duplicates the logic in the live AuthRateLimitService, but is never used anywhere in the codebase. A repo-wide search for LoginRateLimitService turns up only its own class declaration and constructor.

The actual rate limiter that's wired into the login flow is a different-but-similarly-named class.

What problem does this solve for you?

The two class names are close enough (LoginRateLimitService vs. AuthRateLimitService) that it's easy to get them confusing when debugging or developing, which is what happened to me when researching #2601.

Anything else?

No response

Want to help out?

Yes! I'd love to help implement this

Before submitting

• I've searched existing discussions and this hasn't been suggested yet
• I've reviewed this report and have completed it as fully as I can

[davemachado]

Opened as an issue #2603