We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOTE: if you are reporting is a potential security vulnerability or a crash, please follow our CVE process at https://github.com/grpc/proposal/blob/master/P4-grpc-cve-process.md instead of filing an issue here.
Please see the FAQ in our main README.md, then answer the questions below before submitting your issue.
https://github.com/grpc/grpc-go/blob/89737ae09d06cf745ebeb3c414a83c94b58709e5/examples/helloworld/greeter_server/main.go
go version
n/a
I looked to see a good example for graceful shutdown
The example ( https://github.com/grpc/grpc-go/blob/89737ae09d06cf745ebeb3c414a83c94b58709e5/examples/helloworld/greeter_server/main.go ) to show graceful shutdown on a signal
The following:
s := grpc.NewServer() pb.RegisterGreeterServer(s, &server{}) log.Printf("server listening at %v", lis.Addr()) if err := s.Serve(lis); err != nil { log.Fatalf("failed to serve: %v", err) }
There is also nothing in the Go docs ( https://grpc.io/docs/languages/go/basics/#starting-the-server ) about draining requests / etc on shutdown or signal.
I think this should be in the docs/example as every app needs this. Would you accept a PR to add it?
The text was updated successfully, but these errors were encountered:
I think the correct code is:
// graceful stop ch := make(chan os.Signal, 1) signal.Notify(ch, os.Interrupt, syscall.SIGTERM) go func() { <-ch server.GracefulStop() }() // startup lis, err := net.Listen("tcp", ":27166") if err != nil { panic(fmt.Sprintf("failed to listen: %v", err)) } slog.Info("server listening", "addr", lis.Addr()) if err := server.Serve(lis); err != nil { panic(fmt.Sprintf("failed to serve: %v", err)) }
but I'm new to gRPC and would like an authoritative example
Sorry, something went wrong.
No branches or pull requests
NOTE: if you are reporting is a potential security vulnerability or a crash,
please follow our CVE process at
https://github.com/grpc/proposal/blob/master/P4-grpc-cve-process.md instead of
filing an issue here.
Please see the FAQ in our main README.md, then answer the questions below
before submitting your issue.
What version of gRPC are you using?
https://github.com/grpc/grpc-go/blob/89737ae09d06cf745ebeb3c414a83c94b58709e5/examples/helloworld/greeter_server/main.go
What version of Go are you using (
go version
)?n/a
What operating system (Linux, Windows, …) and version?
n/a
What did you do?
I looked to see a good example for graceful shutdown
What did you expect to see?
The example ( https://github.com/grpc/grpc-go/blob/89737ae09d06cf745ebeb3c414a83c94b58709e5/examples/helloworld/greeter_server/main.go ) to show graceful shutdown on a signal
What did you see instead?
The following:
There is also nothing in the Go docs ( https://grpc.io/docs/languages/go/basics/#starting-the-server ) about draining requests / etc on shutdown or signal.
I think this should be in the docs/example as every app needs this. Would you accept a PR to add it?
The text was updated successfully, but these errors were encountered: