You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was reviewing https://grpc.io/docs/guides/cancellation/ to better learn the semantics of context.Context lifetime semantics in the server-side handlers. The document currently mentions only what happens client-side, but we know (through experience) that in grpc-go that the gRPC library cancels the context.Context server-side once the handler completes.
If you modify the example from the basics guide, you can demonstrate this:
I would like to propose modifying minimally the cancellation guide and possibly the basics guide to convey this fact. The standard net/http library does this with (*http.Request).Context, which is better than nothing, but not very visibly. I'd like to take a similar approach here. This is a pretty key thing for users to know in terms of designing their servers correctly.
I'd be happy to do the documentation cleanup myself; I am just filing the bug to signal intent and give the maintainers a chance to chime in if they want this cleanup done in a different way.
The text was updated successfully, but these errors were encountered:
Hi folks,
I was reviewing https://grpc.io/docs/guides/cancellation/ to better learn the semantics of
context.Context
lifetime semantics in the server-side handlers. The document currently mentions only what happens client-side, but we know (through experience) that in grpc-go that the gRPC library cancels thecontext.Context
server-side once the handler completes.If you modify the example from the basics guide, you can demonstrate this:
I would like to propose modifying minimally the cancellation guide and possibly the basics guide to convey this fact. The standard
net/http
library does this with(*http.Request).Context
, which is better than nothing, but not very visibly. I'd like to take a similar approach here. This is a pretty key thing for users to know in terms of designing their servers correctly.I'd be happy to do the documentation cleanup myself; I am just filing the bug to signal intent and give the maintainers a chance to chime in if they want this cleanup done in a different way.
The text was updated successfully, but these errors were encountered: