Skip to content

Commit ebabfd6

Browse files
authored
Add returning of error in case if artifact is not found in github release info (#110)
1 parent 7173349 commit ebabfd6

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ func downloadReleaseAssets(logger *logrus.Logger, assetRegex string, destPath st
416416

417417
release, releaseInfoErr := GetGitHubReleaseInfo(githubRepo, tag)
418418
if releaseInfoErr != nil {
419-
return nil, err
419+
return nil, releaseInfoErr
420420
}
421421

422422
assets, err := findAssetsInRelease(assetRegex, release)

main_test.go

+18
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package main
22

33
import (
44
"fmt"
5+
"github.com/stretchr/testify/assert"
56
"os"
67
"testing"
78
)
@@ -95,3 +96,20 @@ func TestInvalidReleaseAssetsRegex(t *testing.T) {
9596
t.Fatalf("Expected error for invalid regex")
9697
}
9798
}
99+
100+
func TestInvalidReleaseAssetTag(t *testing.T) {
101+
tmpDir := mkTempDir(t)
102+
logger := GetProjectLogger()
103+
testInst := GitHubInstance{
104+
BaseUrl: "github.com",
105+
ApiUrl: "api.github.com",
106+
}
107+
108+
githubRepo, err := ParseUrlIntoGitHubRepo(SAMPLE_RELEASE_ASSET_GITHUB_REPO_URL, "", testInst)
109+
if err != nil {
110+
t.Fatalf("Failed to parse sample release asset GitHub URL into Fetch GitHubRepo struct: %s", err)
111+
}
112+
113+
_, fetchErr := downloadReleaseAssets(logger, SAMPLE_RELEASE_ASSET_REGEX, tmpDir, githubRepo, "6.6.6", false)
114+
assert.Error(t, fetchErr)
115+
}

0 commit comments

Comments
 (0)