Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc-helper module #700

Open
Dentrax opened this issue Nov 6, 2020 · 4 comments
Open

Add grpc-helper module #700

Dentrax opened this issue Nov 6, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@Dentrax
Copy link

Dentrax commented Nov 6, 2020

It would be great! 🌮

@yorinasub17 yorinasub17 added enhancement New feature or request needs use case Needs a compelling use case labels Nov 6, 2020
@yorinasub17
Copy link
Contributor

Thanks for filing the request!

However, I think this would need a use case before we move forward with it. To elaborate, currently we have the http-helper module which provides various modules for making http web calls to arbitrary endpoint, and is more direct (as you are making the calls from the test process). What would be the advantage of using curl over those functions?

Separately, we have the shell module which should make it fairly easy to call curl from your test function should you need it.

@yorinasub17 yorinasub17 self-assigned this Nov 6, 2020
@Dentrax
Copy link
Author

Dentrax commented Nov 7, 2020

Thanks for detailed explanation! I didn't see http-helper module. shell module sounds interesting. I can call a curl command directly by using it then!

As we all know, curl is one of the most using HTTP tool. If we have full curl command then, we can easily pass this to terratest in order to get result, instead of parse whole curl and headers, body, queries, etc.

For gRPC, evans is great! Have you considered to add a grpc-helper module in your roadmap too?

@yorinasub17
Copy link
Contributor

As we all know, curl is one of the most using HTTP tool. If we have full curl command then, we can easily pass this to terratest in order to get result, instead of parse whole curl and headers, body, queries, etc.

I think http-helper is basically that. I think we are more inclined to enhance that library as opposed to introducing yet another way to make HTTP requests with curl. Let us know if there are limitations with using the http-helper library for your use case, and we can discuss how we can enhance it to support your needs!

For gRPC, evans is great! Have you considered to add a grpc-helper module in your roadmap too?

This isn't in our roadmap currently, but we are definitely happy to maintain and review PRs to add such a module if anyone has the need and wants to take ownership!

@yorinasub17 yorinasub17 removed their assignment Nov 25, 2020
@infraredgirl infraredgirl changed the title Consider add curl module Add grpc-helper module Jan 12, 2021
@infraredgirl
Copy link
Contributor

I renamed the issue to reflect the outcome of this conversation.

@infraredgirl infraredgirl added help wanted and removed needs use case Needs a compelling use case labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants