Skip to content

[View Mode]: Back button doesn't return to editor #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
PetbkA opened this issue Feb 17, 2025 · 2 comments · Fixed by #2521
Closed
4 tasks done

[View Mode]: Back button doesn't return to editor #2530

PetbkA opened this issue Feb 17, 2025 · 2 comments · Fixed by #2521
Assignees

Comments

@PetbkA
Copy link

PetbkA commented Feb 17, 2025

⚠️ This issue respects the following points: ⚠️

  • This is a bug. Not a question or feature request.
  • The topic is not already reported at Issues. (I've searched it).
  • Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

In #588 there were discussion about Back navbar button work in view mode which, as I guess, ended with:

The Edit button in Viewer only acts as hide viewer, as back button does too

But at least in 1.24.0 it returns to Files tab instead of editor, and you have to stretch your fingers to reach Edit mode UI button to avoid reopening file.

Prefer view flag doesn't change this behavior.

It would be nice if Back button would return to Edit mode from View mode

Steps to reproduce

  1. Uncheck Prefer view flag;
  2. Open MarkDown file for editing and enter View mode;
  3. Press Back on OS navbar

Information

Android version: 13 (crDroid 9.14)
Device: Xiaomi Redmi Note 12 Turbo 12/512
App Version:

  1. Markor: 2.14.0
  2. Marder: 2.14.0-1820

Source

GitHub Releases

Format / File type

Markdown

Additional info / Log

-
@harshad1
Copy link
Collaborator

iirc this was done on purpose. We wan't to go back and switch mode as we want to preserver the last view setting. i.e. if you close the file in view mode (via back or otherwise) it will open back up in view mode.

@harshad1
Copy link
Collaborator

harshad1 commented Mar 6, 2025

I have a fix for this in #2521

Need to improve MainActivity start performance 2x though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants