Implement safe io #871

A6GibKm · 2022-12-28T09:20:57Z

Needs reviewing

Stuff thats missing

gio/Cargo.toml

A6GibKm · 2022-12-28T09:58:28Z

Added commit descriptions where there were api questions.

A6GibKm · 2022-12-28T10:58:42Z

~~stuff that takes impl AsFd should take &impl AsFd.~~ Done.

gio/src/unix_fd_list.rs

glib/src/functions.rs

sdroege

Seems good to me otherwise

A6GibKm · 2023-07-02T08:17:09Z

Rebased. There were quite many conflicts so a review would be appreciated.

sdroege · 2023-07-03T07:52:25Z

Is this ready for another review and potentially merging?

A6GibKm · 2023-07-03T16:49:49Z

Is this ready for another review and potentially merging?

Yes and maybe

gio/src/desktop_app_info.rs

gio/src/subprocess_launcher.rs

gio/src/unix_fd_list.rs

gio/src/unix_output_stream.rs

sdroege · 2024-06-08T09:10:23Z

glib/src/functions.rs

-    stderr_fd: V,
+    stdin_fd: Option<impl AsFd>,
+    stdout_fd: Option<impl AsFd>,
+    stderr_fd: Option<impl AsFd>,


Option<impl ...> is usually a bad idea. Just try calling this function with a None :)

I think here and in the other APIs using an Option<impl ...> currently you'll have to add a builder pattern instead

sdroege · 2024-06-08T09:11:09Z

glib/src/functions.rs

@@ -238,7 +241,7 @@ pub fn compute_checksum_for_string(

 #[cfg(unix)]
 #[doc(alias = "g_unix_open_pipe")]
-pub fn unix_open_pipe(flags: i32) -> Result<(RawFd, RawFd), Error> {
+pub unsafe fn unix_open_pipe(flags: i32) -> Result<(RawFd, RawFd), Error> {


Should probably return OwnedFd?

Is that compatible with the flags argument that allows setting O_CLOEXEC/FD_CLOEXEC?

As a prior art rustix::fd::open also returns OwnedFd and allows passing in the CLOEXEC flag.

sdroege · 2024-06-08T09:11:21Z

glib/src/functions.rs

@@ -132,7 +135,7 @@ pub fn spawn_async_with_fds<P: AsRef<std::path::Path>, T: AsRawFd, U: AsRawFd, V
 #[cfg(not(windows))]
 #[cfg_attr(docsrs, doc(cfg(not(windows))))]
 #[doc(alias = "g_spawn_async_with_pipes")]
-pub fn spawn_async_with_pipes<
+pub unsafe fn spawn_async_with_pipes<


Why not make this use the new traits?

sdroege · 2024-06-08T09:14:17Z

glib/src/source.rs

@@ -872,14 +872,14 @@ where
 /// The default main loop almost always is the main loop of the main thread.
 /// Thus, the closure is called on the main thread.
 #[doc(alias = "g_unix_fd_add_full")]
-pub fn unix_fd_add<F>(fd: RawFd, condition: IOCondition, func: F) -> SourceId


I think these functions all need to be unsafe actually. impl AsFd is correct but it's up to the caller to ensure that the fd is valid long enough

A6GibKm · 2025-03-18T11:48:35Z

Perhaps we could split this into smaller chunks.

sdroege · 2025-03-19T11:37:08Z

Go for it, or maybe @nagisa wants to take this over to bring it over the finish line?

A6GibKm · 2025-03-19T19:30:26Z

Go for it, or maybe @nagisa wants to take this over to bring it over the finish line?

See #1687.

bilelmoussaoui · 2025-05-25T06:52:27Z

@A6GibKm would you mind rebasing this one? i would like to switch to 2024 edition before the next breaking release

sdroege · 2025-05-25T07:17:04Z

How does this relate to 2024 edition? But regardless, it would be nice to finish this :)

A6GibKm · 2025-05-25T11:00:51Z

I think all the important bits were added in #1687 and #1696. I will check and close if this is the case.

A6GibKm · 2025-06-21T09:50:02Z

Rebased. unix_fd_add: Port to safe-io seems to be the only commit which is close to being finished and could be moved forward. Should I open a new PR for it?

sdroege · 2025-06-21T09:51:22Z

Sure, go ahead :)

A6GibKm · 2025-06-21T10:09:49Z

I am closing in favor of #1745. If someone wants to pick up wip: unix_fd_list: Use custom iterator for steal_fds, feel free to do so.

sdroege · 2025-06-21T12:48:46Z

Can you create an issue for tracking the missing parts?

A6GibKm marked this pull request as draft December 28, 2022 09:44

sdroege reviewed Dec 28, 2022

View reviewed changes

gio/Cargo.toml Outdated Show resolved Hide resolved

A6GibKm force-pushed the safe-io branch 2 times, most recently from 1200fdd to 281adac Compare December 28, 2022 09:56

A6GibKm force-pushed the safe-io branch 4 times, most recently from 2b2aeee to b8c5eb6 Compare December 28, 2022 10:37

A6GibKm force-pushed the safe-io branch from b8c5eb6 to ec13f5d Compare December 28, 2022 16:40

sdroege added this to the 0.17.0 milestone Jan 3, 2023

sdroege reviewed Jan 4, 2023

View reviewed changes

gio/src/unix_fd_list.rs Outdated Show resolved Hide resolved

sdroege reviewed Jan 4, 2023

View reviewed changes

glib/src/functions.rs Outdated Show resolved Hide resolved

sdroege reviewed Jan 4, 2023

View reviewed changes

sdroege modified the milestones: 0.17.0, 0.18.0 Jan 21, 2023

A6GibKm force-pushed the safe-io branch 2 times, most recently from 16e67be to 86cfed9 Compare January 27, 2023 14:46

A6GibKm marked this pull request as ready for review July 2, 2023 07:54

A6GibKm marked this pull request as draft July 2, 2023 08:00

A6GibKm force-pushed the safe-io branch from 86cfed9 to c52f425 Compare July 2, 2023 08:16

A6GibKm force-pushed the safe-io branch from c52f425 to 713878b Compare July 2, 2023 08:25

sdroege reviewed Aug 7, 2023

View reviewed changes

gio/src/desktop_app_info.rs Outdated Show resolved Hide resolved

sdroege reviewed Aug 7, 2023

View reviewed changes

gio/src/subprocess_launcher.rs Outdated Show resolved Hide resolved

sdroege reviewed Aug 7, 2023

View reviewed changes

gio/src/unix_fd_list.rs Outdated Show resolved Hide resolved

sdroege reviewed Aug 7, 2023

View reviewed changes

gio/src/unix_fd_list.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 8, 2024

View reviewed changes

gio/src/unix_output_stream.rs Outdated Show resolved Hide resolved

sdroege reviewed Jun 8, 2024

View reviewed changes

A6GibKm force-pushed the safe-io branch from 25264db to c82d4c4 Compare June 10, 2024 18:05

sdroege modified the milestones: 0.20, 0.21 Jul 10, 2024

sdroege mentioned this pull request Mar 17, 2025

[FEATURE REQUEST] adjust unix_add_fd and friends to use BorrowedFd instead of RawFd #1682

Closed

sdroege linked an issue Mar 17, 2025 that may be closed by this pull request

[FEATURE REQUEST] adjust unix_add_fd and friends to use BorrowedFd instead of RawFd #1682

Closed

A6GibKm mentioned this pull request Mar 19, 2025

Port some functions to safe-io: pt I #1687

Merged

A6GibKm mentioned this pull request Mar 30, 2025

Port some functions to safe-io: pt II #1696

Merged

A6GibKm and others added 5 commits June 21, 2025 11:46

unix_fd_add: Port to safe-io

e94afa1

glib: Mark unix_open_pipe as unsafe

4e66a7e

spawn_async_with_fds: Mark as unsafe

733d06f

unix_streams: Rename and remove unsafe version

1d6321d

wip: unix_fd_list: Use custom iterator for steal_fds

696197e

A6GibKm force-pushed the safe-io branch from c82d4c4 to 696197e Compare June 21, 2025 09:48

A6GibKm mentioned this pull request Jun 21, 2025

unix_fd_add: Port to safe-io #1745

Open

A6GibKm closed this Jun 21, 2025

Uh oh!

Implement safe io #871

Implement safe io #871

Uh oh!

Conversation

A6GibKm commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

A6GibKm commented Dec 28, 2022

Uh oh!

A6GibKm commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sdroege left a comment

Choose a reason for hiding this comment

Uh oh!

A6GibKm commented Jul 2, 2023

Uh oh!

sdroege commented Jul 3, 2023

Uh oh!

A6GibKm commented Jul 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sdroege Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

sdroege Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

A6GibKm Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

sdroege Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

nagisa Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

sdroege Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

sdroege Jun 8, 2024

Choose a reason for hiding this comment

Uh oh!

A6GibKm commented Mar 18, 2025

Uh oh!

sdroege commented Mar 19, 2025

Uh oh!

A6GibKm commented Mar 19, 2025

Uh oh!

bilelmoussaoui commented May 25, 2025

Uh oh!

sdroege commented May 25, 2025

Uh oh!

A6GibKm commented May 25, 2025

Uh oh!

A6GibKm commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdroege commented Jun 21, 2025

Uh oh!

A6GibKm commented Jun 21, 2025

Uh oh!

sdroege commented Jun 21, 2025

Uh oh!

Uh oh!

A6GibKm commented Dec 28, 2022 •

edited

Loading

A6GibKm commented Dec 28, 2022 •

edited

Loading

A6GibKm commented Jun 21, 2025 •

edited

Loading