Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity app fails to render error page #26953

Open
cemms1 opened this issue Mar 5, 2024 · 1 comment
Open

Identity app fails to render error page #26953

cemms1 opened this issue Mar 5, 2024 · 1 comment

Comments

@cemms1
Copy link
Contributor

cemms1 commented Mar 5, 2024

We are currently masking almost all errors in the identity app as the error page is failing to render.

The error message contains:

utils.CleanedException: (common.Assets.AssetNotFoundException): Cannot find asset css/sections/errors-v2.css. You should run `make compile`.
	at dev.DevAssetsController.$anonfun$at$4(DevAssetsController.scala:47)
	at scala.Option.getOrElse(Option.scala:201)
	at dev.DevAssetsController.$anonfun$at$1(DevAssetsController.scala:47)
...

If this app is still being used we should fix this error page so that we return "real" errors rather than these ones.

@coldlink
Copy link
Member

coldlink commented Mar 5, 2024

Identity still own this application.

The identity application in frontend doesn't do much now, theres a card in our backlog to clean it up.

Interesting about the css file. In our vcl it doubles as a fallback route for anything we can't match, so assuming its coming from something we can't match a route to: https://github.com/guardian/identity-platform/blob/69109b0a14a542e574dac40a850dfb4436cca2d4/fastly/profile-theguardian-com.vcl#L288

If Okta is throwing an error because google auth is broken, it might be trying to show a css file that it owns on its page, but we don't have a valid route for that.

We'll investigate further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants