Merge pull request #4240 from tig/v2_4239-Charmap

Author: tig

Terminal.Gui/App/RunState.cs

@@ -44,15 +44,16 @@ protected virtual void Dispose (bool disposing)
     }
 
 #if DEBUG_IDISPOSABLE
+#pragma warning disable CS0419 // Ambiguous reference in cref attribute
     /// <summary>
-    ///     Gets whether <see cref="Dispose"/> was called on this RunState or not.
+    ///     Gets whether <see cref="RunState.Dispose"/> was called on this RunState or not.
     ///     For debug purposes to verify objects are being disposed properly.
     ///     Only valid when DEBUG_IDISPOSABLE is defined.
     /// </summary>
     public bool WasDisposed { get; private set; }
 
     /// <summary>
-    ///     Gets the number of times <see cref="Dispose"/> was called on this object.
+    ///     Gets the number of times <see cref="RunState.Dispose"/> was called on this object.
     ///     For debug purposes to verify objects are being disposed properly.
     ///     Only valid when DEBUG_IDISPOSABLE is defined.
     /// </summary>
@@ -71,5 +72,6 @@ public RunState ()
     {
         Instances.Add (this);
     }
+#pragma warning restore CS0419 // Ambiguous reference in cref attribute
 #endif
 }

Terminal.Gui/ViewBase/View.cs

@@ -520,6 +520,7 @@ protected bool OnTitleChanging (ref string newTitle)
     #endregion
 
 #if DEBUG_IDISPOSABLE
+#pragma warning disable CS0419 // Ambiguous reference in cref attribute
     /// <summary>
     ///     Gets or sets whether failure to appropriately call Dispose() on a View will result in an Assert.
     ///     The default is <see langword="true"/>.
@@ -529,15 +530,16 @@ protected bool OnTitleChanging (ref string newTitle)
     /// </summary>
     public static bool EnableDebugIDisposableAsserts { get; set; } = true;
 
+
     /// <summary>
-    ///     Gets whether <see cref="Dispose"/> was called on this view or not.
+    ///     Gets whether <see cref="View.Dispose"/> was called on this view or not.
     ///     For debug purposes to verify objects are being disposed properly.
     ///     Only valid when DEBUG_IDISPOSABLE is defined.
     /// </summary>
     public bool WasDisposed { get; private set; }
 
     /// <summary>
-    ///     Gets the number of times <see cref="Dispose"/> was called on this view.
+    ///     Gets the number of times <see cref="View.Dispose"/> was called on this view.
     ///     For debug purposes to verify objects are being disposed properly.
     ///     Only valid when DEBUG_IDISPOSABLE is defined.
     /// </summary>
@@ -550,5 +552,6 @@ protected bool OnTitleChanging (ref string newTitle)
     ///     Only valid when DEBUG_IDISPOSABLE is defined.
     /// </summary>
     public static ConcurrentBag<View> Instances { get; private set; } = [];
+#pragma warning restore CS0419 // Ambiguous reference in cref attribute
 #endif
 }

Terminal.Gui/Views/CharMap/CharMap.cs

@@ -681,14 +681,20 @@ private void ShowDetails ()
                                    {
                                        CopyGlyph ();
                                        dlg!.RequestStop ();
+                                       a.Handled = true;
                                    };
 
             copyCodepoint.Accepting += (s, a) =>
                                        {
                                            CopyCodePoint ();
                                            dlg!.RequestStop ();
+                                           a.Handled = true;
                                        };
-            cancel.Accepting += (s, a) => dlg!.RequestStop ();
+            cancel.Accepting += (s, a) =>
+                                {
+                                    dlg!.RequestStop ();
+                                    a.Handled = true;
+                                };
 
             var rune = (Rune)SelectedCodePoint;
             var label = new Label { Text = "IsAscii: ", X = 0, Y = 0 };
@@ -765,9 +771,6 @@ private void ShowDetails ()
                                    Strings.btnOk
                                   );
         }
-
-        // BUGBUG: This is a workaround for some weird ScrollView related mouse grab bug
-        Application.MouseGrabHandler.GrabMouse (this);
     }
 
     #endregion Details Dialog