Skip to content

Commit cce9d9c

Browse files
Add a note about ethers.js problem
1 parent 34a7b09 commit cce9d9c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

typescript/src/ethereum.ts

+6
Original file line numberDiff line numberDiff line change
@@ -772,6 +772,12 @@ export class Bridge
772772
options?: GetEvents.Options,
773773
...filterArgs: Array<unknown>
774774
): Promise<RedemptionRequestedEvent[]> {
775+
// FIXME: Filtering by indexed walletPubKeyHash field may not work
776+
// until https://github.com/ethers-io/ethers.js/pull/4244 is
777+
// included in the currently used version of ethers.js.
778+
// Ultimately, we should upgrade ethers.js to include that fix.
779+
// Short-term, we can workaround the problem as presented in:
780+
// https://github.com/threshold-network/token-dashboard/blob/main/src/threshold-ts/tbtc/index.ts#L1041C1-L1093C1
775781
const events: EthersEvent[] = await this.getEvents(
776782
"RedemptionRequested",
777783
options,

0 commit comments

Comments
 (0)